Bug 149128 - Control characters (Unicode category Cc) should be rendered visibly
Summary: Control characters (Unicode category Cc) should be rendered visibly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar, WPTImpact
Depends on: 215643
Blocks:
  Show dependency treegraph
 
Reported: 2015-09-14 14:01 PDT by Myles C. Maxfield
Modified: 2024-03-28 18:05 PDT (History)
9 users (show)

See Also:


Attachments
Patch (57.64 KB, patch)
2021-08-12 19:47 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (66.50 KB, patch)
2021-08-12 21:11 PDT, Myles C. Maxfield
zalan: review+
Details | Formatted Diff | Diff
Patch for committing (107.11 KB, patch)
2021-08-21 22:45 PDT, Myles C. Maxfield
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Myles C. Maxfield 2015-09-14 18:28:26 PDT
See also https://bugs.webkit.org/show_bug.cgi?id=149142
Comment 2 Sam Sneddon [:gsnedders] 2021-06-11 17:42:15 PDT
Through the /css/css-text/white-space/control-chars-* tests, this accounts for about 60 towards the browser-specific-failures for Safari on https://wpt.fyi (i.e., 1.5% of current failures).
Comment 3 Radar WebKit Bug Importer 2021-06-11 17:42:35 PDT
<rdar://problem/79224941>
Comment 4 Myles C. Maxfield 2021-08-12 13:46:50 PDT
Considering fixing this in https://bugs.webkit.org/show_bug.cgi?id=215643
Comment 5 Myles C. Maxfield 2021-08-12 19:47:58 PDT
Created attachment 435468 [details]
Patch
Comment 6 Myles C. Maxfield 2021-08-12 21:11:13 PDT
Created attachment 435470 [details]
Patch
Comment 7 Myles C. Maxfield 2021-08-12 21:13:28 PDT
Comment on attachment 435470 [details]
Patch

Marking as r?. EWS will show some red, but that's just because this patch depends on https://bugs.webkit.org/show_bug.cgi?id=215643 which hasn't been landed yet.
Comment 8 Myles C. Maxfield 2021-08-21 22:45:34 PDT
Created attachment 436110 [details]
Patch for committing
Comment 9 EWS Watchlist 2021-08-21 22:46:39 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 10 Myles C. Maxfield 2021-08-22 01:14:09 PDT
I need to investigate the iOS test failures.
Comment 11 Myles C. Maxfield 2021-08-22 14:05:01 PDT
Committed r281419 (240809@main): <https://commits.webkit.org/240809@main>
Comment 12 Myles C. Maxfield 2021-09-03 14:04:16 PDT
Committed r282021 (241326@main): <https://commits.webkit.org/241326@main>