| Summary: | [WebGL2] Various parameters should be non-nullable in IDL | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||||
| Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, changseok, darin, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, hi, joepeck, kbr, kondapallykalyan, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 126404 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
James Darpinian
2020-08-18 11:10:42 PDT
Created attachment 406794 [details]
Patch
Comment on attachment 406794 [details]
Patch
The patch looks good but some tests are failing. Could you resolve those failures and ping when there's a new patch up? Thanks.
Created attachment 406815 [details]
Patch
Created attachment 406818 [details]
Patch
Lots of wrong and broken tests needed fixing. I think this patch should pass now. Comment on attachment 406818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review > LayoutTests/ChangeLog:17 > + * fast/canvas/webgl/context-lost-expected.txt: > + * fast/canvas/webgl/context-lost.html: > + * fast/canvas/webgl/error-reporting-expected.txt: > + * fast/canvas/webgl/error-reporting.html: > + * fast/canvas/webgl/get-active-test-expected.txt: > + * fast/canvas/webgl/get-active-test.html: > + * fast/canvas/webgl/gl-object-get-calls-expected.txt: > + * fast/canvas/webgl/gl-object-get-calls.html: > + * fast/canvas/webgl/null-object-behaviour-expected.txt: > + * fast/canvas/webgl/null-object-behaviour.html: If any of these are redundant tests, you should feel free to cut them down. Oops, I didn’t wait long enough to see if the tests pass. Please don’t land until you know they pass. Comment on attachment 406818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review Fantastic work James! One question. > LayoutTests/fast/canvas/webgl/error-reporting.html:-21 > -// synthetic GL errors. This test verifies the raising of certain Was the removal of this part of the comment intentional? Comment on attachment 406818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406818&action=review >> LayoutTests/ChangeLog:17 >> + * fast/canvas/webgl/null-object-behaviour.html: > > If any of these are redundant tests, you should feel free to cut them down. Thanks, yes, they are redundant to some in webgl/1.0.3 and webgl/2.0.0. Next time I'll try deleting redundant tests instead of attempting to fix them. >> LayoutTests/fast/canvas/webgl/error-reporting.html:-21 >> -// synthetic GL errors. This test verifies the raising of certain > > Was the removal of this part of the comment intentional? You're right, this was unintentional. Comment on attachment 406818 [details]
Patch
Looks like I missed rebaselining two tests.
Created attachment 406820 [details]
Patch
Comment on attachment 406820 [details]
Patch
Looks good! r+
Committed r265841: <https://trac.webkit.org/changeset/265841> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406820 [details]. |