Summary: | [WebGL2] Conformance tests throttled by iframe leaving viewport | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||||||
Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, kbr, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 126404, 189641 | ||||||||||
Attachments: |
|
Description
James Darpinian
2020-08-10 16:44:00 PDT
Created attachment 406346 [details]
Patch
Reduces the number of test timeouts in webgl/2.0.0 from 160 to 3 (+~6 flaky timeouts). Comment on attachment 406346 [details]
Patch
Great diagnosis and fix James! This is a huge reliability improvement for these tests!
LGTM but I don't have reviewer privileges.
Tools/Scripts/svn-apply failed to apply attachment 406346 [details] to trunk.
Please resolve the conflicts and upload a new patch.
James, sorry but I introduced conflicts with your patch in Bug 214765 - expando-loss-expected.txt and expando-loss-2-expected.txt. Created attachment 406424 [details]
Rebase
Created attachment 406425 [details]
Rebase
Sorry, last patch was messed up, this one should be correct.
Tools/Scripts/svn-apply failed to apply attachment 406425 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment on attachment 406346 [details] Patch Trying CQ+ after reverting of the previously-colliding patch from Bug 214765. Committed r265534: <https://trac.webkit.org/changeset/265534> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406346 [details]. |