Bug 215346

Summary: [WebGL2] Conformance tests throttled by iframe leaving viewport
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: WebGLAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, kbr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404, 189641    
Attachments:
Description Flags
Patch
none
Rebase
none
Rebase ews-feeder: commit-queue-

James Darpinian
Reported 2020-08-10 16:44:00 PDT
[WebGL2] Conformance tests throttled by iframe leaving viewport
Attachments
Patch (4.89 MB, patch)
2020-08-10 17:08 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Rebase (4.91 MB, patch)
2020-08-11 15:15 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Rebase (4.89 MB, patch)
2020-08-11 15:19 PDT, James Darpinian 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-08-10 17:08:25 PDT
Created attachment 406346 [details] Patch
James Darpinian
Comment 2 2020-08-10 17:11:42 PDT
Reduces the number of test timeouts in webgl/2.0.0 from 160 to 3 (+~6 flaky timeouts).
Kenneth Russell
Comment 3 2020-08-10 21:34:40 PDT
Comment on attachment 406346 [details] Patch Great diagnosis and fix James! This is a huge reliability improvement for these tests! LGTM but I don't have reviewer privileges.
EWS
Comment 4 2020-08-11 12:43:35 PDT
Tools/Scripts/svn-apply failed to apply attachment 406346 [details] to trunk. Please resolve the conflicts and upload a new patch.
Kenneth Russell
Comment 5 2020-08-11 12:55:08 PDT
James, sorry but I introduced conflicts with your patch in Bug 214765 - expando-loss-expected.txt and expando-loss-2-expected.txt.
James Darpinian
Comment 6 2020-08-11 15:15:12 PDT
Created attachment 406424 [details] Rebase
James Darpinian
Comment 7 2020-08-11 15:19:07 PDT
Created attachment 406425 [details] Rebase Sorry, last patch was messed up, this one should be correct.
EWS
Comment 8 2020-08-11 15:24:06 PDT
Tools/Scripts/svn-apply failed to apply attachment 406425 [details] to trunk. Please resolve the conflicts and upload a new patch.
Kenneth Russell
Comment 9 2020-08-11 15:51:35 PDT
Comment on attachment 406346 [details] Patch Trying CQ+ after reverting of the previously-colliding patch from Bug 214765.
EWS
Comment 10 2020-08-11 16:14:23 PDT
Committed r265534: <https://trac.webkit.org/changeset/265534> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406346 [details].
Radar WebKit Bug Importer
Comment 11 2020-08-11 16:15:37 PDT
<rdar://problem/66868577>
Note You need to log in before you can comment on or make changes to this bug.