Bug 215346 - [WebGL2] Conformance tests throttled by iframe leaving viewport
Summary: [WebGL2] Conformance tests throttled by iframe leaving viewport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks: 126404 189641
  Show dependency tree / graph
 
Reported: 2020-08-10 16:44 PDT by James Darpinian
Modified: 2020-08-11 16:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.89 MB, patch)
2020-08-10 17:08 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
Rebase (4.91 MB, patch)
2020-08-11 15:15 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
Rebase (4.89 MB, patch)
2020-08-11 15:19 PDT, James Darpinian 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-08-10 16:44:00 PDT 
[WebGL2] Conformance tests throttled by iframe leaving viewport
Comment 1 James Darpinian 2020-08-10 17:08:25 PDT 
Created attachment 406346 [details]
Patch
Comment 2 James Darpinian 2020-08-10 17:11:42 PDT 
Reduces the number of test timeouts in webgl/2.0.0 from 160 to 3 (+~6 flaky timeouts).
Comment 3 Kenneth Russell 2020-08-10 21:34:40 PDT 
Comment on attachment 406346 [details]
Patch

Great diagnosis and fix James! This is a huge reliability improvement for these tests!

LGTM but I don't have reviewer privileges.
Comment 4 EWS 2020-08-11 12:43:35 PDT 
Tools/Scripts/svn-apply failed to apply attachment 406346 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 5 Kenneth Russell 2020-08-11 12:55:08 PDT 
James, sorry but I introduced conflicts with your patch in Bug 214765 - expando-loss-expected.txt and expando-loss-2-expected.txt.
Comment 6 James Darpinian 2020-08-11 15:15:12 PDT 
Created attachment 406424 [details]
Rebase
Comment 7 James Darpinian 2020-08-11 15:19:07 PDT 
Created attachment 406425 [details]
Rebase

Sorry, last patch was messed up, this one should be correct.
Comment 8 EWS 2020-08-11 15:24:06 PDT 
Tools/Scripts/svn-apply failed to apply attachment 406425 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 9 Kenneth Russell 2020-08-11 15:51:35 PDT 
Comment on attachment 406346 [details]
Patch

Trying CQ+ after reverting of the previously-colliding patch from Bug 214765.
Comment 10 EWS 2020-08-11 16:14:23 PDT 
Committed r265534: <https://trac.webkit.org/changeset/265534>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406346 [details].
Comment 11 Radar WebKit Bug Importer 2020-08-11 16:15:37 PDT 
<rdar://problem/66868577>