Bug 215036

Summary: [WebGL2] Upgrade vertexAttribPointer with new supported types
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 126938, 214211    
Bug Blocks: 126404    
Attachments:
Description Flags
Patch
none
Patch
none
add tests none

Kenneth Russell
Reported 2020-07-31 15:14:42 PDT
Based on some feedback from the Filament team, and examining WebGLRenderingContextBase::vertexAttribPointer (which isn't overridden in WebGL2RenderingContext), it looks like vertexAttribPointer needs to be upgraded to support the new types in WebGL 2.0 / OpenGL ES 3.0.
Attachments
Patch (2.66 KB, patch)
2020-08-03 16:55 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2020-08-03 17:28 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
add tests (12.02 KB, patch)
2020-08-05 17:44 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-07-31 15:30:00 PDT
When this is fixed, let's make sure to test with the Filament team's test case to see whether it's working.
James Darpinian
Comment 2 2020-08-03 16:55:06 PDT
Created attachment 405886 [details] Patch
James Darpinian
Comment 3 2020-08-03 16:57:19 PDT
This doesn't appear to be tested at all by the conformance tests as far as I can tell. I'm working on adding some tests.
James Darpinian
Comment 4 2020-08-03 17:28:48 PDT
Created attachment 405894 [details] Patch
James Darpinian
Comment 5 2020-08-03 17:37:32 PDT
Confirmed that this fixes the Filament test case :)
Kenneth Russell
Comment 6 2020-08-04 12:42:37 PDT
Comment on attachment 405894 [details] Patch Looks good!
Dean Jackson
Comment 7 2020-08-04 12:50:18 PDT
Comment on attachment 405894 [details] Patch Can we get a test (or WebGL conformance test) for this?
Dean Jackson
Comment 8 2020-08-04 12:50:48 PDT
Comment on attachment 405894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405894&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Please note here that a test is coming in the WebGL suite.
James Darpinian
Comment 9 2020-08-05 17:44:43 PDT
Created attachment 406062 [details] add tests
James Darpinian
Comment 10 2020-08-05 17:45:38 PDT
Comment on attachment 406062 [details] add tests I went ahead and updated the conformance tests.
Kenneth Russell
Comment 11 2020-08-05 18:41:06 PDT
Comment on attachment 406062 [details] add tests Looks good - thanks for patching up the conformance tests James!
EWS
Comment 12 2020-08-05 18:58:14 PDT
Committed r265317: <https://trac.webkit.org/changeset/265317> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406062 [details].
Radar WebKit Bug Importer
Comment 13 2020-08-05 18:59:18 PDT
<rdar://problem/66604955>
Note You need to log in before you can comment on or make changes to this bug.