Summary: | Use more inclusive terminology in Tools | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | darin, ews-watchlist, mkwst, sam, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 213092 | ||||||||||||||
Attachments: |
|
Description
Alex Christensen
2020-07-30 09:09:42 PDT
Created attachment 405577 [details]
Patch
Created attachment 405579 [details]
patch
Created attachment 405582 [details]
patch
Comment on attachment 405582 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=405582&action=review > LayoutTests/ChangeLog:21 > + * http/tests/xmlhttprequest/origin-whitelisting-all.html: > + * http/tests/xmlhttprequest/origin-whitelisting-exact-match.html: > + * http/tests/xmlhttprequest/origin-whitelisting-https.html: > + * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html: > + * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html: > + * http/tests/xmlhttprequest/origin-whitelisting-removal.html: > + * http/tests/xmlhttprequest/origin-whitelisting-subdomains.html: Probably worth renaming the tests while you are doing this. Created attachment 405586 [details]
Patch
Comment on attachment 405586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405586&action=review > LayoutTests/ChangeLog:21 > + * http/tests/security/local-image-from-remote-whitelisted.html: > + * http/tests/xmlhttprequest/origin-whitelisting-all.html: > + * http/tests/xmlhttprequest/origin-whitelisting-exact-match.html: > + * http/tests/xmlhttprequest/origin-whitelisting-https.html: > + * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html: > + * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html: > + * http/tests/xmlhttprequest/origin-whitelisting-removal.html: > + * http/tests/xmlhttprequest/origin-whitelisting-subdomains.html: Probably want to regenerate this ChangeLog. Created attachment 405714 [details]
Patch
Committed r265169: <https://trac.webkit.org/changeset/265169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405714 [details]. Comment on attachment 405714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405714&action=review > Source/WebKitLegacy/win/WebView.cpp:6992 > + unsigned blockListCount, __inout_ecount_full(blockListCount) BSTR* blocklist, Mix of blockList and blocklist here. |