Bug 214971 - Use more inclusive terminology in Tools
Summary: Use more inclusive terminology in Tools
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks: 213092
  Show dependency tree / graph
 
Reported: 2020-07-30 09:09 PDT by Alex Christensen
Modified: 2020-08-04 15:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (49.87 KB, patch)
2020-07-30 09:14 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (55.11 KB, patch)
2020-07-30 09:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (55.11 KB, patch)
2020-07-30 09:57 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (113.68 KB, patch)
2020-07-30 10:16 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (120.49 KB, patch)
2020-07-31 11:31 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-07-30 09:09:42 PDT 
Use more inclusive terminology in Tools
Comment 1 Alex Christensen 2020-07-30 09:14:18 PDT 
Created attachment 405577 [details]
Patch
Comment 2 Alex Christensen 2020-07-30 09:24:04 PDT 
Created attachment 405579 [details]
patch
Comment 3 Alex Christensen 2020-07-30 09:57:44 PDT 
Created attachment 405582 [details]
patch
Comment 4 Sam Weinig 2020-07-30 10:03:44 PDT 
Comment on attachment 405582 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405582&action=review

> LayoutTests/ChangeLog:21
> +        * http/tests/xmlhttprequest/origin-whitelisting-all.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-exact-match.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-https.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-removal.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-subdomains.html:

Probably worth renaming the tests while you are doing this.
Comment 5 Alex Christensen 2020-07-30 10:16:39 PDT 
Created attachment 405586 [details]
Patch
Comment 6 Sam Weinig 2020-07-30 10:22:29 PDT 
Comment on attachment 405586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405586&action=review

> LayoutTests/ChangeLog:21
> +        * http/tests/security/local-image-from-remote-whitelisted.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-all.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-exact-match.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-https.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-removal.html:
> +        * http/tests/xmlhttprequest/origin-whitelisting-subdomains.html:

Probably want to regenerate this ChangeLog.
Comment 7 Alex Christensen 2020-07-31 11:31:16 PDT 
Created attachment 405714 [details]
Patch
Comment 8 EWS 2020-07-31 17:30:13 PDT 
Committed r265169: <https://trac.webkit.org/changeset/265169>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405714 [details].
Comment 9 Radar WebKit Bug Importer 2020-07-31 17:31:18 PDT 
<rdar://problem/66406437>
Comment 10 Darin Adler 2020-08-04 15:22:37 PDT 
Comment on attachment 405714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405714&action=review

> Source/WebKitLegacy/win/WebView.cpp:6992
> +    unsigned blockListCount, __inout_ecount_full(blockListCount) BSTR* blocklist,

Mix of blockList and blocklist here.