RESOLVED FIXED 214971
Use more inclusive terminology in Tools 
https://bugs.webkit.org/show_bug.cgi?id=214971
Summary Use more inclusive terminology in Tools
Alex Christensen
Reported 2020-07-30 09:09:42 PDT
Use more inclusive terminology in Tools
Attachments
Patch (49.87 KB, patch)
2020-07-30 09:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch (55.11 KB, patch)
2020-07-30 09:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
patch (55.11 KB, patch)
2020-07-30 09:57 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (113.68 KB, patch)
2020-07-30 10:16 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (120.49 KB, patch)
2020-07-31 11:31 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-07-30 09:14:18 PDT
Created attachment 405577 [details] Patch
Alex Christensen
Comment 2 2020-07-30 09:24:04 PDT
Created attachment 405579 [details] patch
Alex Christensen
Comment 3 2020-07-30 09:57:44 PDT
Created attachment 405582 [details] patch
Sam Weinig
Comment 4 2020-07-30 10:03:44 PDT
Comment on attachment 405582 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=405582&action=review > LayoutTests/ChangeLog:21 > + * http/tests/xmlhttprequest/origin-whitelisting-all.html: > + * http/tests/xmlhttprequest/origin-whitelisting-exact-match.html: > + * http/tests/xmlhttprequest/origin-whitelisting-https.html: > + * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html: > + * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html: > + * http/tests/xmlhttprequest/origin-whitelisting-removal.html: > + * http/tests/xmlhttprequest/origin-whitelisting-subdomains.html: Probably worth renaming the tests while you are doing this.
Alex Christensen
Comment 5 2020-07-30 10:16:39 PDT
Created attachment 405586 [details] Patch
Sam Weinig
Comment 6 2020-07-30 10:22:29 PDT
Comment on attachment 405586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405586&action=review > LayoutTests/ChangeLog:21 > + * http/tests/security/local-image-from-remote-whitelisted.html: > + * http/tests/xmlhttprequest/origin-whitelisting-all.html: > + * http/tests/xmlhttprequest/origin-whitelisting-exact-match.html: > + * http/tests/xmlhttprequest/origin-whitelisting-https.html: > + * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html: > + * http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html: > + * http/tests/xmlhttprequest/origin-whitelisting-removal.html: > + * http/tests/xmlhttprequest/origin-whitelisting-subdomains.html: Probably want to regenerate this ChangeLog.
Alex Christensen
Comment 7 2020-07-31 11:31:16 PDT
Created attachment 405714 [details] Patch
EWS
Comment 8 2020-07-31 17:30:13 PDT
Committed r265169: <https://trac.webkit.org/changeset/265169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405714 [details].
Radar WebKit Bug Importer
Comment 9 2020-07-31 17:31:18 PDT
<rdar://problem/66406437>
Darin Adler
Comment 10 2020-08-04 15:22:37 PDT
Comment on attachment 405714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405714&action=review > Source/WebKitLegacy/win/WebView.cpp:6992 > + unsigned blockListCount, __inout_ecount_full(blockListCount) BSTR* blocklist, Mix of blockList and blocklist here.
Note You need to log in before you can comment on or make changes to this bug.