Bug 214936

Summary: Remove deprecated script and stylesheet injection SPI, replaced with more inclusively-named SPI
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213092    
Attachments:
Description Flags
Patch none

Description Alex Christensen 2020-07-29 14:38:22 PDT
Remove deprecated script and stylesheet injection SPI, replaced with more inclusively-named SPI
Comment 1 Alex Christensen 2020-07-29 14:39:27 PDT
Created attachment 405504 [details]
Patch
Comment 2 Alex Christensen 2020-07-29 14:41:16 PDT
Comment on attachment 405504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405504&action=review

> Source/WebKitLegacy/mac/ChangeLog:8
> +        rdar://64376341 tracks the adoption of the replacement.  Once that is done, we can remove the old SPI.

Note: we will have to wait for this to be integrated before landing this, but feel free to review before then.
Comment 3 Radar WebKit Bug Importer 2020-08-05 14:39:19 PDT
<rdar://problem/66594434>
Comment 4 EWS 2020-09-21 22:07:18 PDT
Committed r267397: <https://trac.webkit.org/changeset/267397>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405504 [details].
Comment 5 Alex Christensen 2020-09-29 12:16:53 PDT
Reverted r267397 for reason:

SPI is still used

Committed r267756: <https://trac.webkit.org/changeset/267756>
Comment 6 Alex Christensen 2020-09-29 12:19:46 PDT
The problem mentioned in rdar://problem/66227777 also needs to be resolved before this can be re-landed.
Comment 7 Alex Christensen 2020-11-03 19:13:32 PST
We unfortunately need to wait another 6 months or so before retrying this.
Comment 8 Alex Christensen 2021-01-13 14:40:52 PST
http://trac.webkit.org/r271456