|Summary:||Migrate App-Bound Domains code from WebKit Additions|
|Severity:||Normal||CC:||aakash_jain, ap, bfulgham, commit-queue, webkit-bot-watchers-bugzilla|
|Version:||WebKit Local Build|
|Bug Depends on:||214917|
Description katherine_cheney 2020-07-28 12:24:36 PDT
We should migrate some additional app-bound domains code to WebKit
Comment 9 katherine_cheney 2020-07-28 14:06:12 PDT
Having some trouble making EWS happy, hopefully this one does it...
Comment 12 Brent Fulgham 2020-07-28 15:33:06 PDT
Comment on attachment 405419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405419&action=review r=me, but please correct the ChangeLog that includes Ryan's description, too. > Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:192 > + @"NSRemindersUsageDescription", Can you please remove the "NSRemindersUsageDescription", we are not restricting this one anymore. > LayoutTests/ChangeLog:11 > + Oops! Two ChangeLog entries.
Comment 13 katherine_cheney 2020-07-28 15:39:36 PDT
(In reply to Brent Fulgham from comment #12) > Comment on attachment 405419 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405419&action=review > > r=me, but please correct the ChangeLog that includes Ryan's description, too. > Whoops -- accidentally absorbed that along the way. Will fix. > > Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:192 > > + @"NSRemindersUsageDescription", > Yes, will do. > Can you please remove the "NSRemindersUsageDescription", we are not > restricting this one anymore. > > > LayoutTests/ChangeLog:11 > > + > > Oops! Two ChangeLog entries. Good catch!
Comment 14 katherine_cheney 2020-07-28 15:49:30 PDT
Created attachment 405422 [details] Patch for landing
Comment 15 EWS 2020-07-28 16:14:14 PDT
Committed r265018: <https://trac.webkit.org/changeset/265018> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405422 [details].
Comment 16 Aakash Jain 2020-07-29 04:51:42 PDT
This (In reply to EWS from comment #15) > Committed r265018: <https://trac.webkit.org/changeset/265018> This seems to have broken various ios-wk2 tests. Tracked in Bug 214916. Please make sure to run the patches through EWS before landing. In this case there were 10 patches uploaded within ~2 hours, and none of the patches were run through ios-wk2, api-ios, mac-debug-wk1, win EWSes.
Comment 19 katherine_cheney 2020-07-29 11:12:33 PDT
Thanks Aakash -- my bad on not letting EWS finish. I am unable to reproduce these failures locally, so I am uploading this patch with some logging to try and figure out what is going on on EWS.