Bug 21483

Summary: Regression: run-webkit-tests --pixel svg fails with diffs which aren't diffs
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, changelog
eric: review+
Alternate solution mitz: review+

Eric Seidel (no email)
Reported 2008-10-08 13:33:32 PDT
run-webkit-tests --pixel svg fails with diffs which aren't diffs the perl script seems to get confused as to what's what. It's spitting out png dumps as diffs and doing image diffs between the pixel results of the wrong two tests. Something in the output stream from DRT must have gotten run-webkit-tests confused. This is a regression as this used to work just fine.
Attachments
Patch, changelog (6.27 KB, patch)
2008-10-08 15:34 PDT, Simon Fraser (smfr) 		eric: review+
DetailsFormatted DiffDiff
Alternate solution (6.53 KB, patch)
2008-10-08 17:41 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2008-10-08 13:38:41 PDT
Fallout from bug 21124 and bug 21323
Simon Fraser (smfr)
Comment 2 2008-10-08 15:34:19 PDT
Created attachment 24203 [details] Patch, changelog This patch changes DRT to print an ExpectPNG: line to the output when it knows it will spew out PNG data. The script can then look for this, rather than guessing. It also adds a little Content-Type checking.
Eric Seidel (no email)
Comment 3 2008-10-08 15:43:09 PDT
Comment on attachment 24203 [details] Patch, changelog Looks fine.
Simon Fraser (smfr)
Comment 4 2008-10-08 17:41:15 PDT
Created attachment 24210 [details] Alternate solution This second patch makes DRT always dump two #EOF-terminated blocks; the second, for PNG data, may be empty.
mitz
Comment 5 2008-10-08 17:43:53 PDT
Comment on attachment 24210 [details] Alternate solution r=me, assuming you tested in the various scenarios (--pixel, --pixel with no existing results, tests that dump as text and tests that don't etc.).
Simon Fraser (smfr)
Comment 6 2008-10-08 17:47:18 PDT
r37433 = 8c2bac03b93d3aa1c8b2667ebc9ce1c20dcb3d04 (trunk) M WebKitTools/DumpRenderTree/cg/PixelDumpSupportCG.cpp M WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp M WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests
Note You need to log in before you can comment on or make changes to this bug.