| Summary: | Fix validation of deleted WebGL objects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Darpinian <jdarpinian> | ||||
| Component: | WebGL | Assignee: | James Darpinian <jdarpinian> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 126404, 126940 | ||||||
| Attachments: |
|
||||||
|
Description
James Darpinian
2020-07-21 17:08:58 PDT
Created attachment 404882 [details]
Patch
I discovered this while looking at conformance tests for query objects (bug 126940). Comment on attachment 404882 [details]
Patch
Looks good to me. Good catch.
Do you think we should bring over two additional concepts from Chromium's WebGL implementation?
- WebGLObject::MarkedForDeletion
- WebGLRenderingContextBase::ValidateNullableWebGLObject
?
Maybe not in this patch, but in a follow-on one?
Yes, I think there's more work to be done here. Thanks, sounds good. This individual patch LGTM - let's file follow-on bugs. Committed r264713: <https://trac.webkit.org/changeset/264713> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404882 [details]. |