Bug 214535

Summary: JSC build scripts should be quiet by default
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: JavaScriptCoreAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2020-07-19 07:27:10 PDT
Some of our build scripts have started printing "Nothing changed" on successful operation. For example: [354/2150] Generating ../../DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h OffsetExtractor: Nothing changed. [481/2150] Generating ../../DerivedSources/JavaScriptCore/LLIntAssembly.h Offlineasm: Nothing changed. The build logs are nicer if, between 'cmake' and 'cmake install', we only print stuff when there is an actual problem that needs to be investigated. We achieved this long ago (bug #152382) and only a couple changes are needed to get there again.
Attachments
Patch (2.66 KB, patch)
2020-07-19 07:31 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-07-19 07:31:58 PDT
Created attachment 404669 [details] Patch
EWS
Comment 2 2020-07-20 13:19:31 PDT
Committed r264616: <https://trac.webkit.org/changeset/264616> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404669 [details].
Radar WebKit Bug Importer
Comment 3 2020-07-20 13:20:14 PDT
<rdar://problem/65844029>
Note You need to log in before you can comment on or make changes to this bug.