Summary: | [GTK] Prepare unit tests for GTK4 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aperez, berto, bugs-noreply, ews-watchlist, gustavo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | Gtk, InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 210100, 214344 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2020-07-13 02:49:27 PDT
Created attachment 404140 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 404140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404140&action=review > Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:45 > + g_main_context_iteration(nullptr, TRUE); Wow, it's amazing that it's 2020 and we were still using the gtk_* main loop functions 😅️ Committed r264647: <https://trac.webkit.org/changeset/264647> |