Bug 214147

Summary: Add EWS queues for tvOS and watchOS builders
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dean_johnson, jbedard, jlewis3, ryanhaddad, slewis, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=213402
https://bugs.webkit.org/show_bug.cgi?id=214279
https://bugs.webkit.org/show_bug.cgi?id=214214
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-07-09 10:25:47 PDT
Add EWS queues for tvOS and watchOS. It would prevent people from accidentally breaking these configurations.
Attachments
Patch (12.68 KB, patch)
2020-07-09 10:36 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-07-09 10:36:44 PDT
Created attachment 403886 [details] Patch
Ryan Haddad
Comment 2 2020-07-09 11:54:47 PDT
Comment on attachment 403886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403886&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46 > + ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win', I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'.
Aakash Jain
Comment 3 2020-07-09 12:19:18 PDT
(In reply to Ryan Haddad from comment #2) > > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46 > > + ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win', > > I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'. These names appear in status-bubbles on Bugzilla, so I was trying to keep them small (similar to 'mac' instead of 'macos').
Ryan Haddad
Comment 4 2020-07-09 12:24:55 PDT
(In reply to Aakash Jain from comment #3) > (In reply to Ryan Haddad from comment #2) > > > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46 > > > + ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win', > > > > I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'. > These names appear in status-bubbles on Bugzilla, so I was trying to keep > them small (similar to 'mac' instead of 'macos'). If keeping the bubbles small is a priority, that's fine.
Dean Johnson
Comment 5 2020-07-09 13:23:07 PDT
Comment on attachment 403886 [details] Patch Unofficial r=me. Code looks good.
EWS
Comment 6 2020-07-09 14:23:52 PDT
Committed r264196: <https://trac.webkit.org/changeset/264196> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403886 [details].
Radar WebKit Bug Importer
Comment 7 2020-07-09 14:24:16 PDT
<rdar://problem/65290635>
Aakash Jain
Comment 8 2020-07-13 18:00:02 PDT
Minor follow-up fix: https://trac.webkit.org/changeset/264327/webkit
Note You need to log in before you can comment on or make changes to this bug.