Bug 214279 – [ews] watchos should build both arm64_32 and armv7k architectures

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

watchos queue in EWS should build both arm64_32 and armv7k architectures. This will help in preventing build breakage on both architectures.

[Aakash Jain]

Created attachment 404181 [details]
Patch

[Aakash Jain]

Sample run: https://ews-build.webkit-uat.org/#/builders/42/builds/81

[Keith Miller]

(In reply to Aakash Jain from comment #2)
> Sample run: https://ews-build.webkit-uat.org/#/builders/42/builds/81

I don't see any clang invocations using armv7k? Are you sure that's right? Does it need to be a clean build?

[Darin Adler]

I did review+ because the change looks logical and the EWS is green for watchOS.

But maybe it’s not working. Keith’s question does seem relevant.

[Aakash Jain]

(In reply to Keith Miller from comment #3)
> (In reply to Aakash Jain from comment #2)
> I don't see any clang invocations using armv7k? Are you sure that's right? Does it need to be a clean build?
That was due to missing parameter 'ONLY_ACTIVE_ARCH=NO'. Fixed that in https://trac.webkit.org/r264327. Current patch should be good now.

However, it seems like the build is broken for armv7k, e.g.: https://ews-build.webkit-uat.org/#/builders/42/builds/93

In file included from Source/WebCore/editing/TextIterator.h:28:
Source/WebCore/editing/CharacterRange.h:74:26: error: implicit conversion loses integer precision: 'const uint64_t' (aka 'const unsigned long long') to 'CFIndex' (aka 'long') [-Werror,-Wshorten-64-to-32]

[Darin Adler]

We had a lot of breakage like this a while back. Someone changed the warning settings I think? Maybe Jonathan Bedard?

[Darin Adler]

There are other kinds of fixes for those warnings, but I think changing the settings is what someone chose to do.

[Jonathan Bedard]

(In reply to Darin Adler from comment #6)
> We had a lot of breakage like this a while back. Someone changed the warning
> settings I think? Maybe Jonathan Bedard?

That was the fix, although we need a bit more that that for armv7k, I'll have a patch ready on https://bugs.webkit.org/show_bug.cgi?id=214306 shortly.

[EWS]

Committed r264358: <https://trac.webkit.org/changeset/264358>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404181 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65555319>

[Aakash Jain]

Deployed on the EWS server. Seems to be working fine, e.g.: https://ews-build.webkit.org/#/builders/41/builds/342/steps/7/logs/stdio