Bug 213402 – Bring up watchOS/tvOS on build.webkit.org

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Now that watchOS and tvOS can be built with the public SDK, we should include these configurations in automation.

[Radar WebKit Bug Importer]

<rdar://problem/64542588>

[Jonathan Bedard]

Created attachment 402316 [details]
Patch

[Aakash Jain]

Comment on attachment 402316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402316&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:242
> +                      "name": "Apple AppleTV 13 Release (Build)", "type": "Build", "builddir": "appletv-13-release",

Let’s avoid space and symbols in builder name, so that it helps when we upgrade to new buildbot version.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:247
> +                      "name": "Apple AppleTV Simulator 13 Release (Build)", "type": "Build", "builddir": "appletv-simulator-13-release",

Apple AppleTV  seems weird. Maybe we should replace AppleTV with tvOS everywhere in this patch.

[Ryan Haddad]

(In reply to Aakash Jain from comment #3)
> Comment on attachment 402316 [details]
> Apple AppleTV  seems weird. Maybe we should replace AppleTV with tvOS
> everywhere in this patch.

+1 on this suggestion.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #3)
> Comment on attachment 402316 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402316&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:242
> > +                      "name": "Apple AppleTV 13 Release (Build)", "type": "Build", "builddir": "appletv-13-release",
> 
> Let’s avoid space and symbols in builder name, so that it helps when we
> upgrade to new buildbot version.
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:247
> > +                      "name": "Apple AppleTV Simulator 13 Release (Build)", "type": "Build", "builddir": "appletv-simulator-13-release",
> 
> Apple AppleTV  seems weird. Maybe we should replace AppleTV with tvOS
> everywhere in this patch.

And actually, to that point, it's actually --tvos-*** when building anyways.

[Jonathan Bedard]

Created attachment 402328 [details]
Patch

[Jonathan Bedard]

Comment on attachment 402328 [details]
Patch

Landed: <https://trac.webkit.org/changeset/263291/webkit>

[Jonathan Bedard]

Committed r263300: <https://trac.webkit.org/changeset/263300>

[Jonathan Bedard]

watchOS builds are still broken, there is another change incoming.

[Jonathan Bedard]

Committed r263310: <https://trac.webkit.org/changeset/263310>

[Alexey Proskuryakov]

-        "Apple-watchOS-6-Release-Build": {platform: Dashboard.Platform.watchOS6Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
+        "Apple-watchOS-6-Release-Build": {platform: Dashboard.Platform.watchOS6Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},

I think that we want to show arm64_32 as 64-bit, first because it really is 64-bit at architecture level, and also to avoid confusion with armv7k. Thoughts?

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 402404 [details]
Patch

[EWS]

Committed r263319: <https://trac.webkit.org/changeset/263319>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402404 [details].

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #11)
> -        "Apple-watchOS-6-Release-Build": {platform:
> Dashboard.Platform.watchOS6Device, debug: false, builder: true,
> architecture: Buildbot.BuildArchitecture.SixtyFourBit},
> +        "Apple-watchOS-6-Release-Build": {platform:
> Dashboard.Platform.watchOS6Device, debug: false, builder: true,
> architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
> 
> I think that we want to show arm64_32 as 64-bit, first because it really is
> 64-bit at architecture level, and also to avoid confusion with armv7k.
> Thoughts?

I'm fine with switching this back to 64 bit. I went back and forth with it. When I hear '64 bit arm' I think 'arm64' and 'arm64e'

[Alexey Proskuryakov]

Looks like no one disagreed, so please change that back.

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 402487 [details]
Patch

[EWS]

Committed r263358: <https://trac.webkit.org/changeset/263358>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402487 [details].