Bug 213809

Summary: [css-flex] Remove dead code paths when evaluating percentage resolution
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213739    
Attachments:
Description Flags
Patch
none
Patch rego: review+

Sergio Villar Senin
Reported 2020-06-30 12:29:28 PDT
[css-flex] Remove death paths when evaluating percentage resolution
Attachments
Patch (5.07 KB, patch)
2020-06-30 12:35 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (5.09 KB, patch)
2020-07-01 03:27 PDT, Sergio Villar Senin 		rego: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-06-30 12:35:26 PDT
Created attachment 403225 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-06-30 13:49:38 PDT
Can you use a less dramatic name than "death paths"? Do you mean "dead code" paths?
Sergio Villar Senin
Comment 3 2020-07-01 03:25:06 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Can you use a less dramatic name than "death paths"? Do you mean "dead code" > paths? Yeah :), that's what I meant after all.
Sergio Villar Senin
Comment 4 2020-07-01 03:27:31 PDT
Created attachment 403281 [details] Patch
Manuel Rego Casasnovas
Comment 5 2020-07-01 03:30:45 PDT
Comment on attachment 403281 [details] Patch r=me, nice catch!
Sergio Villar Senin
Comment 6 2020-07-01 03:36:52 PDT
Committed r263792: <https://trac.webkit.org/changeset/263792>
Radar WebKit Bug Importer
Comment 7 2020-07-01 03:37:14 PDT
<rdar://problem/64980540>
Note You need to log in before you can comment on or make changes to this bug.