Bug 213733

Summary: Use properly flag name for testcases of Tools/Scripts/run-builtins-generator-tests
Product: WebKit Reporter: Tetsuharu Ohzeki [UTC+9] <tetsuharu.ohzeki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=213728
Attachments:
Description Flags
Patch none

Tetsuharu Ohzeki [UTC+9]
Reported 2020-06-29 08:43:07 PDT
Test cases under Source/JavaScriptCore/Scripts/tests/builtins/ uses exist compilation flags. They are confusable if we remove a compilation flag and I think it's better to rename to more proper ones. See also bug 213728
Attachments
Patch (24.20 KB, patch)
2020-06-30 05:26 PDT, Tetsuharu Ohzeki [UTC+9] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tetsuharu Ohzeki [UTC+9]
Comment 1 2020-06-30 05:26:29 PDT
Created attachment 403190 [details] Patch
EWS
Comment 2 2020-07-01 00:09:50 PDT
Committed r263790: <https://trac.webkit.org/changeset/263790> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403190 [details].
Radar WebKit Bug Importer
Comment 3 2020-07-01 00:10:16 PDT
<rdar://problem/64974907>
Note You need to log in before you can comment on or make changes to this bug.