Bug 213441

Summary: Keyframe animation doesn't 't show up in the Animations timeline
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, eric.carlson, ews-watchlist, glenn, hi, inspector-bugzilla-changes, jer.noble, joepeck, keith_miller, mark.lam, msaboff, philipj, saam, sergio, simon.fraser, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=189687
https://bugs.webkit.org/show_bug.cgi?id=213499
Attachments:
Description Flags
Testcase
none
Patch
none
Patch none

Description Simon Fraser (smfr) 2020-06-20 20:15:33 PDT 
Created attachment 402413 [details]
Testcase

With the attached testcase, I don't see a green bar in the "Media and Animations" bar in the timelines tab, even after reload. Webkit r263322 inspected by Safari at r263222.
Comment 1 Simon Fraser (smfr) 2020-06-20 20:22:33 PDT 
Doesn't work with Safari inspecting itself either.
Comment 2 Devin Rousso 2020-06-22 20:05:58 PDT 
Created attachment 402529 [details]
Patch
Comment 3 Devin Rousso 2020-06-22 21:14:12 PDT 
Created attachment 402532 [details]
Patch
Comment 4 EWS Watchlist 2020-06-22 21:14:48 PDT 
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 5 BJ Burg 2020-06-23 08:51:09 PDT 
Comment on attachment 402532 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402532&action=review

r=me. EWS failure seems unrelated.

> Source/WebInspectorUI/UserInterface/Models/Animation.js:252
> +                // COMPATIBILITY (iOS 14): an iteration count of `Infinity` was not properly handled.

Nice.
Comment 6 EWS 2020-06-23 09:12:41 PDT 
Committed r263400: <https://trac.webkit.org/changeset/263400>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402532 [details].
Comment 7 Radar WebKit Bug Importer 2020-06-23 09:13:15 PDT 
<rdar://problem/64646884>