Bug 213421

Summary: Delete dead code for old ews api tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=170062
https://bugs.webkit.org/show_bug.cgi?id=170028
Bug Depends on:    
Bug Blocks: 213296    
Attachments:
Description Flags
Patch ap: review+

Aakash Jain
Reported 2020-06-19 17:33:08 PDT
Delete dead code for old ews api tests. See Bug 213296 for details of old ews code deletion plan. The code was dead code, as it was never completed and never used in production. There were few required parts of the logic missing like retrying without patch (in order to figure out whether the failure is introduced by the patch or is pre-existing).
Attachments
Patch (13.93 KB, patch)
2020-06-19 17:35 PDT, Aakash Jain 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-06-19 17:35:05 PDT
Created attachment 402360 [details] Patch
Aakash Jain
Comment 2 2020-06-19 17:46:15 PDT
> Created attachment 402360 [details] This effectively reverts r214363 and r214377.
Alexey Proskuryakov
Comment 3 2020-06-19 18:19:41 PDT
Comment on attachment 402360 [details] Patch rs=me
Aakash Jain
Comment 4 2020-06-19 18:22:55 PDT
Committed r263308: <https://trac.webkit.org/changeset/263308>
Radar WebKit Bug Importer
Comment 5 2020-06-19 18:23:15 PDT
<rdar://problem/64551723>
Note You need to log in before you can comment on or make changes to this bug.