Bug 213088

Summary:

Style checker should check for non-inclusive terminology

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, bdakin, darin, ews-watchlist, glenn, jbedard, ryanhaddad, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

213092

Attachments:

Description	Flags
Patch	none
Patch	none

Simon Fraser (smfr)

Reported 2020-06-11 11:59:58 PDT

The style checker should point out uses of non-inclusive terminology in patches, specifically blacklist/whitelist, master/slave.

Attachments
Patch (9.86 KB, patch) 2021-05-17 13:28 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Patch (9.86 KB, patch) 2021-05-17 14:09 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2020-06-11 14:41:59 PDT

(In reply to Simon Fraser (smfr) from comment #0) > The style checker should point out uses of non-inclusive terminology in > patches, specifically blacklist/whitelist, master/slave. Removing 'slave' references requires transitioning to buildbot 0.9, if I recall (although Aakash is expert here) Removing 'master' references is not something I think we can reasonably track in this bug, as newer versions of buildbot still use it to refer to the 'build-master'. Any generalized git tooling will also use 'master' to refer to the default branch since that's what the vast majority of projects use to refer to their primary branch.

Simon Fraser (smfr)

Comment 2 2020-06-11 20:40:51 PDT

Let's start with blacklist/whitelist.

Aakash Jain

Comment 3 2021-05-17 13:28:00 PDT

Created attachment 428859 [details] Patch

Aakash Jain

Comment 4 2021-05-17 13:30:00 PDT

Style EWS failure in https://ews-build.webkit.org/#/builders/6/builds/47628 is expected (and shows that this code is working).

Jonathan Bedard

Comment 5 2021-05-17 13:32:17 PDT

Comment on attachment 428859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428859&action=review > Tools/Scripts/webkitpy/style/checkers/inclusive_language.py:37 > + 'Line contains non-inclusive term.') Can we print the term considered non-inclusive here too?

Aakash Jain

Comment 6 2021-05-17 14:09:15 PDT

Created attachment 428867 [details] Patch

Aakash Jain

Comment 7 2021-05-17 14:10:19 PDT

(In reply to Jonathan Bedard from comment #5) > Can we print the term considered non-inclusive here too? Done in updated patch.

EWS

Comment 8 2021-05-17 16:12:50 PDT

Committed r277612 (237827@main): <https://commits.webkit.org/237827@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428867 [details].

Radar WebKit Bug Importer

Comment 9 2021-05-17 16:13:19 PDT

<rdar://problem/78127249>

Note You need to log in before you can comment on or make changes to this bug.