Bug 212664

Summary: Revert FEATURES_DEFINES related changes
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, aestes, annulen, apinheiro, cdumez, cfleizach, changseok, darin, dmazzoni, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, jcraig, jdiggs, keith_miller, kondapallykalyan, macpherson, mark.lam, menard, msaboff, pdr, ryuan.choi, saam, samuel_white, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212418, 212420, 212541    
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-06-02 14:41:18 PDT
Bug 262310, Bug 262311, Bug 262318, and Bug 262331 involve changes to FEATURE_DEFINES and how the values there relate to those found in the Platform*.h files. Those changes break XCBuild (by removing the .xcfilelist related to UnifiedSources and the process for generating them), and so are being reverted.
Attachments
Patch (193.79 KB, patch)
2020-06-02 14:45 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-06-02 14:41:31 PDT
<rdar://problem/63893033>
Keith Rollin
Comment 2 2020-06-02 14:45:15 PDT
Created attachment 400856 [details] Patch
Andy Estes
Comment 3 2020-06-02 16:20:06 PDT
Comment on attachment 400856 [details] Patch rs=me. it also seems ok to commit this unreviewed since it fixes the build.
Keith Rollin
Comment 4 2020-06-02 16:24:01 PDT
I thought it a good idea to pass these changes by others since I was reverting their changes without completely understanding them. But I'll keep your advice in mind for the future.
EWS
Comment 5 2020-06-02 16:52:05 PDT
Committed r262462: <https://trac.webkit.org/changeset/262462> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400856 [details].
Note You need to log in before you can comment on or make changes to this bug.