| Summary: | [WinCairo] WKTR WebsiteDataStore is being overwritten by the default one | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Christopher Reid <chris.reid> | ||||||
| Component: | Tools / Tests | Assignee: | Christopher Reid <chris.reid> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | don.olmstead, Hironori.Fujii, ross.kirsling, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=210106 | ||||||||
| Attachments: |
|
||||||||
|
Description
Christopher Reid
2020-05-18 13:39:48 PDT
Created attachment 399673 [details]
patch
Comment on attachment 399673 [details]
patch
There's a related block of code at platformInitializeDataStore which GTK and WPE implement in their respective TestController files. I'd wager that their implementation should just be shared in this file.
Also while you're in there maybe add a !PLATFORM(COCOA) comment at the end of the #if !PLATFORM(COCOA) block this lives in.
(In reply to Don Olmstead from comment #2) > Comment on attachment 399673 [details] > patch > > There's a related block of code at platformInitializeDataStore which GTK and > WPE implement in their respective TestController files. I'd wager that their > implementation should just be shared in this file. > Yeah, for reference wincairo recently started to hit crashes without that change similar to r261758. Created attachment 399697 [details]
Patch for landing
Committed r261846: <https://trac.webkit.org/changeset/261846> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399697 [details]. |