Bug 212031

Summary: webkitpy: Add Source/WebKit/Scripts/webkit as relevant path to webkitpy-ews
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: Tools / TestsAssignee: Lauro Moura <lmoura>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Lauro Moura
Reported 2020-05-18 10:25:04 PDT
Recently bug212008 was opened to fix some tests from Source/WebKit/Scripts/webkit/messages_unittest.py failing in webkitpy step, but the patch did not trigger the webkitpy EWS bot, with EWS citing "No relevant changes". This is happening because webkitpy-ews only watches Tools/Scripts/webkitpy (in Tools/BuildSlaveSupport/ews-build/config.json)
Attachments
Patch (1.48 KB, patch)
2020-05-18 10:30 PDT, Lauro Moura 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-05-18 10:30:40 PDT
Created attachment 399655 [details] Patch
Alexey Proskuryakov
Comment 2 2020-05-18 18:05:28 PDT
Comment on attachment 399655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399655&action=review > Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py:69 > + "Source/WebKit/Scripts/webkit/", Seeing that test-webkitpy exercises this code, sure. Not sure great that test-webkitpy tests code that is not webkitpy.
Lauro Moura
Comment 3 2021-12-09 11:04:11 PST
*** This bug has been marked as a duplicate of bug 222276 ***
Note You need to log in before you can comment on or make changes to this bug.