Bug 211935

Summary: GetByVal and PutByVal runtime operations shouldn't fall off a performance cliff when the property is an integer boxed as a double
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 211877    
Attachments:
Description Flags
patch
ysuzuki: review+
patch for landing none

Saam Barati
Reported 2020-05-14 17:12:40 PDT
...
Attachments
patch (16.84 KB, patch)
2020-05-14 19:04 PDT, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing (17.20 KB, patch)
2020-05-14 21:24 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-05-14 19:04:19 PDT
Created attachment 399442 [details] patch
Yusuke Suzuki
Comment 2 2020-05-14 19:10:07 PDT
Comment on attachment 399442 [details] patch r=me
Mark Lam
Comment 3 2020-05-14 19:21:10 PDT
Comment on attachment 399442 [details] patch r=me too. The style complaint seems legit. Please fix.
Saam Barati
Comment 4 2020-05-14 20:28:50 PDT
(In reply to Mark Lam from comment #3) > Comment on attachment 399442 [details] > patch > > r=me too. The style complaint seems legit. Please fix. I agree, but the code is unrelated to this patch. I can drive by fix it though
Saam Barati
Comment 5 2020-05-14 21:24:49 PDT
Created attachment 399453 [details] patch for landing
EWS
Comment 6 2020-05-14 23:55:11 PDT
Committed r261731: <https://trac.webkit.org/changeset/261731> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399453 [details].
Radar WebKit Bug Importer
Comment 7 2020-05-14 23:56:16 PDT
<rdar://problem/63259625>
Note You need to log in before you can comment on or make changes to this bug.