| Summary: | GetByVal and PutByVal runtime operations shouldn't fall off a performance cliff when the property is an integer boxed as a double | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 211877 | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2020-05-14 17:12:40 PDT
Created attachment 399442 [details]
patch
Comment on attachment 399442 [details]
patch
r=me
Comment on attachment 399442 [details]
patch
r=me too. The style complaint seems legit. Please fix.
(In reply to Mark Lam from comment #3) > Comment on attachment 399442 [details] > patch > > r=me too. The style complaint seems legit. Please fix. I agree, but the code is unrelated to this patch. I can drive by fix it though Created attachment 399453 [details]
patch for landing
Committed r261731: <https://trac.webkit.org/changeset/261731> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399453 [details]. |