Summary: | Make editing/spelling/editing-word-with-marker-2.html test what it claims and make it work on iOS | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | darin, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Local Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=211814 | ||||||||||||||
Bug Depends on: | 133544, 211814 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Daniel Bates
2020-05-12 13:45:36 PDT
Created attachment 399173 [details]
Patch
Comment on attachment 399173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review > LayoutTests/ChangeLog:13 > + The fix for iOS was simple: just enable internals.setContinuousSpellCheckingEnabled(). I didn't ^^^ + use UIHelper to activate the element in a way that brings up the keyboard, focus() alone doesn't do the due to iOS policy + blur() the field between tests for maximal code reuse (otherwise I have to keep track/check if the textarea is focused or patch up UIHelper.activateElementAndWaitForInputSession() so it doesn't hang if keyboard is already showing <-- probably a good thing to patch up, but its out of my way) Comment on attachment 399173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review >> LayoutTests/ChangeLog:13 >> + The fix for iOS was simple: just enable internals.setContinuousSpellCheckingEnabled(). I didn't > > ^^^ + use UIHelper to activate the element in a way that brings up the keyboard, focus() alone doesn't do the due to iOS policy + blur() the field between tests for maximal code reuse (otherwise I have to keep track/check if the textarea is focused or patch up UIHelper.activateElementAndWaitForInputSession() so it doesn't hang if keyboard is already showing <-- probably a good thing to patch up, but its out of my way) And I'm already going out of my way to fix this test...I don't need to fix this test up for what I need to do. Comment on attachment 399173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review > LayoutTests/editing/spelling/editing-word-with-marker-2.html:13 > + + "is added before or after the misspelled word or the caret is moved." > + + "The test succeeds if the word 'meagesga' has a red underline."); Space after the period before the next sentence? > LayoutTests/editing/spelling/editing-word-with-marker-2.html:57 > + debug(`<br>Test: ${testCase.testName}:`); Does \n work too or do you have to use <br>? Created attachment 399196 [details]
Add space between sentences
Created attachment 399197 [details]
Fix for anticipated WK1 failure
Created attachment 399198 [details]
Attempt to fix Mac WK2
I'm going to try, but I may choose to skip on WK2.
Comment on attachment 399173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399173&action=review Thanks for the review. >> LayoutTests/editing/spelling/editing-word-with-marker-2.html:13 >> + + "The test succeeds if the word 'meagesga' has a red underline."); > > Space after the period before the next sentence? Fixed. >> LayoutTests/editing/spelling/editing-word-with-marker-2.html:57 >> + debug(`<br>Test: ${testCase.testName}:`); > > Does \n work too or do you have to use <br>? <br> required (In reply to Daniel Bates from comment #7) > Created attachment 399198 [details] > Attempt to fix Mac WK2 > > I'm going to try, but I may choose to skip on WK2. Experiment failed. Will do what we do now and skip the test on WK2. Created attachment 399556 [details]
To Land
Committed r261783: <https://trac.webkit.org/changeset/261783> |