Bug 211762

Summary: WPT test importer fails to update references in <link> tags
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clopez, ews-watchlist, glenn, jbedard, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=191460
Bug Depends on:    
Bug Blocks: 207734    
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2020-05-11 19:59:15 PDT
When importing WPT tests, the WebKit WPT importer rewrites references inside several tags, but fails to update references inside link tags. This was causing failures when importing the css-flexbox suite in bug 191460 For example the WPT test css/css-flexbox/reference/stretch-input-in-column-ref.html has this: <link href="../support/flexbox.css" rel="stylesheet"> And the test has to be moved from folder css/css-flexbox/reference/ to css/css-flexbox/ in order to be in the same folder than the test. So the link href has to be updated accordingly
Attachments
Patch (5.81 KB, patch)
2020-05-11 20:52 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2020-05-11 20:52:22 PDT
Created attachment 399094 [details] Patch
EWS
Comment 2 2020-05-12 04:18:02 PDT
Committed r261552: <https://trac.webkit.org/changeset/261552> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399094 [details].
Radar WebKit Bug Importer
Comment 3 2020-05-12 04:19:16 PDT
<rdar://problem/63131152>
Note You need to log in before you can comment on or make changes to this bug.