Bug 211484

Summary: [WebGL2] webgl/2.0.0/conformance[2]/textures/image_bitmap* failures
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, jdarpinian, jer.noble, jsbell, justin_fan, kondapallykalyan, philipj, sergio, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 208875    
Bug Blocks: 126404, 189641, 182424, 183438, 216565, 227140    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Kenneth Russell 2020-05-05 20:02:40 PDT 
There are several failures in each test underneath webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/ . Initial triage indicates the failures might be caused by WebKit not respecting the premultiplyAlpha option to createImageBitmap, but it's not clear.

To reduce the size of subsequent texture-related rebaselines, these tests are being skipped for the time being. The failures will need to be investigated before the WebGL 2.0 conformance suite can be passed.
Comment 1 Kenneth Russell 2020-07-30 11:00:50 PDT 
The image_bitmap_from_blob, image_bitmap_from_image and image_bitmap_from_video tests are all failing for the same reason - WebKit doesn't yet implement the imageOrientation or premultiplyAlpha ImageBitmapOptions:

https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html

This is core functionality and is a blocker for conformance - raising to P1, and assigning to dino@ per recent discussion on Slack.

Affected test directories:

webgl/2.0.0/conformance[2]/textures/image_bitmap_from_blob/*
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_image/*
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_video/*
Comment 2 Kenneth Russell 2020-07-30 13:25:50 PDT 
After further discussion with dino@, taking this bug; will attempt a fix.
Comment 3 Kenneth Russell 2020-08-02 15:11:30 PDT 
Created attachment 405813 [details]
Patch
Comment 4 Kenneth Russell 2020-08-02 15:41:05 PDT 
Created attachment 405814 [details]
Patch
Comment 5 Kenneth Russell 2020-08-03 09:07:24 PDT 
The attached patch implements ImageBitmapOptions' ImageOrientation="flipY" and PremultiplyAlpha="premultiply" options, and makes several dozen tests under:
    webgl/2.0.0/conformance[2]/textures/image_bitmap_from_blob/
    webgl/2.0.0/conformance[2]/textures/image_bitmap_from_canvas/
    webgl/2.0.0/conformance[2]/textures/image_bitmap_from_image/
    webgl/2.0.0/conformance[2]/textures/image_bitmap_from_video/

The bulk of the patch is the rebaseline; the code changes are relatively small.
Comment 6 Kenneth Russell 2020-08-03 09:18:02 PDT 
Created attachment 405835 [details]
Patch
Comment 7 EWS 2020-08-03 11:19:11 PDT 
Committed r265208: <https://trac.webkit.org/changeset/265208>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405835 [details].
Comment 8 Radar WebKit Bug Importer 2020-08-03 13:38:26 PDT 
<rdar://problem/66489332>