Bug 211266

Summary: REGRESSION (r258994): Prevents diagnostic logging of network resource loads
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 209522    
Bug Blocks:    
Attachments:
Description Flags
Patch mjs: review+

Brent Fulgham
Reported 2020-04-30 16:31:14 PDT
The change in r258994 was too heavy-handed. Although the SPI is called "_allowSensitiveLogging", it actually prevents any network logging. We need to hold off on adopting this until it is revised to only address sensitive load logging.
Attachments
Patch (1.93 KB, patch)
2020-04-30 16:35 PDT, Brent Fulgham 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2020-04-30 16:33:59 PDT
<rdar://problem/62461099>
Brent Fulgham
Comment 2 2020-04-30 16:35:09 PDT
Created attachment 398121 [details] Patch
Brent Fulgham
Comment 3 2020-05-01 09:42:16 PDT
After speaking with Maciej, we will do this another way.
Brent Fulgham
Comment 4 2020-05-01 16:14:17 PDT
We spoke again, and will take this change, but we need to hold off until a blocking bug is fixed.
Brent Fulgham
Comment 5 2020-05-01 16:14:37 PDT
Note: Holding for <rdar://problem/62727212> to be landed.
Maciej Stachowiak
Comment 6 2020-05-01 23:53:21 PDT
Comment on attachment 398121 [details] Patch Maybe this is a stretch, but is it possible to make an API test that verifies that logging happens when it's supposed to (and not when it isn't supposed to, i.e. private browsing)? In any case, r=me
Brent Fulgham
Comment 7 2020-05-07 15:35:25 PDT
(In reply to Brent Fulgham from comment #5) > Note: Holding for <rdar://problem/62727212> to be landed. Actually, it's <rdar://problem/62901456> we are holding for.
Ahmad Saleem
Comment 8 2022-10-10 14:44:15 PDT
Checking by BugID, it seems this r+ patch didn't landed. Do we need this now? Thanks!
Brent Fulgham
Comment 9 2022-10-10 16:08:40 PDT
Oh! The relevant changes landed in https://trac.webkit.org/changeset/262332/webkit, after coordinating with the CFNetwork changes needed here. We can close this. The fix shipped back in 2020.
Note You need to log in before you can comment on or make changes to this bug.