| Summary: | Web Inspector: Worker: should use the name of the worker if it exists | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 398084 [details]
Patch
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. Comment on attachment 398084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398084&action=review r=me great cleanup! Please investigate Windows EWS failure: C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\JavaScriptCore/InspectorFrontendDispatchers.h(351,10): message : see declaration of 'Inspector::WorkerFrontendDispatcher::workerCreated' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-6.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] > LayoutTests/inspector/worker/runtime-basic-expected.txt:13 > Target - Page - location and href - Location: inspector/worker/runtime-basic.html > Very nice! (In reply to Brian Burg from comment #3) > Please investigate Windows EWS failure: > > C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\JavaScriptCore/InspectorFrontendDispatchers.h(351,10): message : see declaration of 'Inspector::WorkerFrontendDispatcher::workerCreated' (compiling source file C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource-84c9f43f-6.cpp) [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] The windows bot doesn't seem to update/regenerate DerivedSources properly. This has happened a bunch of times when I've made changes to the protocol. A clean build has always fixed the issue. *** Bug 164678 has been marked as a duplicate of this bug. *** Committed r261104: <https://trac.webkit.org/changeset/261104> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398084 [details]. |
test.html ``` let worker = new Worker("worker.js", {name: "My Worker"}); ``` worker.js ``` console.log(self.name); ```