Bug 211243

Summary: REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: REOPENED    
Severity: Normal CC: commit-queue, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211235
Bug Depends on: 139308, 166801, 211587    
Bug Blocks: 211586    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-04-30 11:46:41 PDT
Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m. Regressed here: Bug 139308: Add a private browsing mode to MiniBrowser <https://bugs.webkit.org/show_bug.cgi?id=139308> <https://trac.webkit.org/r176862> Bug 166801: Add the ability to create empty contentEditable windows in MiniBrowser <https://bugs.webkit.org/show_bug.cgi?id=166801> <https://trac.webkit.org/r210483> Found by clang static analyzer.
Attachments
Patch v1 (1.59 KB, patch)
2020-04-30 11:48 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-04-30 11:48:54 PDT
Created attachment 398073 [details] Patch v1
Radar WebKit Bug Importer
Comment 2 2020-04-30 11:49:13 PDT
<rdar://problem/62663549>
David Kilzer (:ddkilzer)
Comment 3 2020-04-30 11:59:28 PDT
Comment on attachment 398073 [details] Patch v1 MiniBrowser is not used in automated testing, so marking cq+ after all builds completed successfully.
EWS
Comment 4 2020-04-30 12:19:50 PDT
Committed r260959: <https://trac.webkit.org/changeset/260959> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398073 [details].
WebKit Commit Bot
Comment 5 2020-05-07 11:55:19 PDT
Re-opened since this is blocked by bug 211587
Radar WebKit Bug Importer
Comment 6 2020-05-07 12:13:25 PDT
<rdar://problem/62987575>
Note You need to log in before you can comment on or make changes to this bug.