Bug 210889

Summary: Jesus Calling app needs more WebSQL
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211896
https://bugs.webkit.org/show_bug.cgi?id=211906
Bug Depends on:    
Bug Blocks: 204907    
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2020-04-22 17:19:38 PDT
Jesus Calling app needs more WebSQL
Attachments
Patch (1.91 KB, patch)
2020-04-22 17:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2020-04-23 13:31 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-04-22 17:20:13 PDT
Created attachment 397293 [details] Patch
Alex Christensen
Comment 2 2020-04-22 17:20:16 PDT
<rdar://problem/61795507>
Chris Dumez
Comment 3 2020-04-23 10:15:17 PDT
Comment on attachment 397293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397293&action=review > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:615 > + static const bool needsWebSQL = IOSApplication::isJesusCalling() && applicationSDKVersion() <= DYLD_IOS_VERSION_12_2; Can we make RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled() return true in this case instead? This is not the only place where RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled() is queried so this fix is incomplete otherwise. There are plenty of places in generated bindings code that check RuntimeEnabledFeatures::sharedFeatures().webSQLEnabled().
Alex Christensen
Comment 4 2020-04-23 13:31:48 PDT
Created attachment 397379 [details] Patch
Chris Dumez
Comment 5 2020-04-23 13:34:52 PDT
Comment on attachment 397379 [details] Patch r=me
EWS
Comment 6 2020-04-23 13:59:56 PDT
Committed r260597: <https://trac.webkit.org/changeset/260597> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397379 [details].
Note You need to log in before you can comment on or make changes to this bug.