|Summary:||[Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK|
|Product:||WebKit||Reporter:||Darin Adler <darin>|
|Component:||WebKit Misc.||Assignee:||Darin Adler <darin>|
|Severity:||Normal||CC:||andersca, annulen, ap, benjamin, cdumez, cmarcelo, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jiewen_tan, keith_miller, kondapallykalyan, mark.lam, msaboff, pdr, ross.kirsling, ryuan.choi, sabouhallawa, sbarati, schenney, sergio, toyoshim, tzagallo, webkit-bug-importer, yutak|
|Version:||WebKit Nightly Build|
|Bug Depends on:||209694|
Description Darin Adler 2020-04-21 21:55:29 PDT
[Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
Comment 2 Darin Adler 2020-04-21 22:05:02 PDT
Almost ready to go. The only remaining problem is that there is a failure with Apple's internal installhdrs mechanism; will definitely need to fix that before landing.
Comment 3 Darin Adler 2020-04-22 13:59:49 PDT Comment hidden (obsolete)
Created attachment 397257 [details] Patch
Comment 4 Darin Adler 2020-04-22 14:00:42 PDT
New patch has everything needed now. This includes more than Anders reviewed, but I took the liberty of still leaving his name in as reviewer. Waiting for feedback before I land it.
Comment 5 Alexey Proskuryakov 2020-04-22 14:01:36 PDT
I was 30 seconds too late to complain about not undoing the StringConcatenate.cpp test workaround in this patch...
Comment 6 Darin Adler 2020-04-22 14:03:36 PDT
(In reply to Alexey Proskuryakov from comment #5) > I was 30 seconds too late to complain about not undoing the > StringConcatenate.cpp test workaround in this patch... (For what it's worth, I had fixed that locally less than 30 seconds after posting the first one.)
Comment 8 Darin Adler 2020-04-22 15:01:27 PDT
Comment on attachment 397261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397261&action=review > Tools/ChangeLog:7 > +2020-04-22 Darin Adler <email@example.com> > + > + [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK > + https://bugs.webkit.org/show_bug.cgi?id=210845 > + > + Reviewed by NOBODY (OOPS!). > + I’ll fix this before landing.
Comment 9 Darin Adler 2020-04-22 18:06:07 PDT
If I don’t get any more comments in the next couple of hours, I’ll land this.
Comment 10 Darin Adler 2020-04-22 21:34:39 PDT
Committed r260554: <https://trac.webkit.org/changeset/260554>