Bug 210845

Summary: [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, annulen, ap, benjamin, cdumez, cmarcelo, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jiewen_tan, keith_miller, kondapallykalyan, mark.lam, msaboff, pdr, ross.kirsling, ryuan.choi, saam, sabouhallawa, schenney, sergio, toyoshim, tzagallo, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210812
https://bugs.webkit.org/show_bug.cgi?id=209694
Bug Depends on: 209694    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Darin Adler
Reported 2020-04-21 21:55:29 PDT
[Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
Attachments
Patch (20.58 KB, patch)
2020-04-21 22:03 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (33.50 KB, patch)
2020-04-22 13:59 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (34.30 KB, patch)
2020-04-22 14:35 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-04-21 22:03:26 PDT
Created attachment 397168 [details] Patch
Darin Adler
Comment 2 2020-04-21 22:05:02 PDT
Almost ready to go. The only remaining problem is that there is a failure with Apple's internal installhdrs mechanism; will definitely need to fix that before landing.
Darin Adler
Comment 3 2020-04-22 13:59:49 PDT Comment hidden (obsolete)
Darin Adler
Comment 4 2020-04-22 14:00:42 PDT
New patch has everything needed now. This includes more than Anders reviewed, but I took the liberty of still leaving his name in as reviewer. Waiting for feedback before I land it.
Alexey Proskuryakov
Comment 5 2020-04-22 14:01:36 PDT
I was 30 seconds too late to complain about not undoing the StringConcatenate.cpp test workaround in this patch...
Darin Adler
Comment 6 2020-04-22 14:03:36 PDT
(In reply to Alexey Proskuryakov from comment #5) > I was 30 seconds too late to complain about not undoing the > StringConcatenate.cpp test workaround in this patch... (For what it's worth, I had fixed that locally less than 30 seconds after posting the first one.)
Darin Adler
Comment 7 2020-04-22 14:35:02 PDT
Created attachment 397261 [details] Patch
Darin Adler
Comment 8 2020-04-22 15:01:27 PDT
Comment on attachment 397261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397261&action=review > Tools/ChangeLog:7 > +2020-04-22 Darin Adler <darin@apple.com> > + > + [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK > + https://bugs.webkit.org/show_bug.cgi?id=210845 > + > + Reviewed by NOBODY (OOPS!). > + I’ll fix this before landing.
Darin Adler
Comment 9 2020-04-22 18:06:07 PDT
If I don’t get any more comments in the next couple of hours, I’ll land this.
Darin Adler
Comment 10 2020-04-22 21:34:39 PDT
Committed r260554: <https://trac.webkit.org/changeset/260554>
Radar WebKit Bug Importer
Comment 11 2020-04-22 21:35:17 PDT
<rdar://problem/62230569>
Note You need to log in before you can comment on or make changes to this bug.