Bug 210812

Summary: WTF API test for StringConcatenate failing for internal Apple builds
Product: WebKit Reporter: Darin Adler <darin>
Component: Tools / TestsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210845
https://bugs.webkit.org/show_bug.cgi?id=209694
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2020-04-21 13:03:31 PDT
WTF API test for StringConcatenate failing for internal Apple builds
Attachments
Patch (2.10 KB, patch)
2020-04-21 13:05 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-04-21 13:05:50 PDT
Created attachment 397107 [details] Patch
Darin Adler
Comment 2 2020-04-21 13:06:17 PDT
<rdar://problem/62117460>
Brent Fulgham
Comment 3 2020-04-21 13:41:37 PDT
Comment on attachment 397107 [details] Patch Thank you for the fix!
EWS
Comment 4 2020-04-21 13:52:58 PDT
Committed r260452: <https://trac.webkit.org/changeset/260452> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397107 [details].
Alexey Proskuryakov
Comment 5 2020-04-21 19:16:53 PDT
Comment on attachment 397107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397107&action=review Looks like a pretty bad handgun to have such code behave differently between build configurations. > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:86 > + // FIXME: Remove this if statement once we have UChar as char16_t in all configurations. Is there a bug to follow to know when this happens?
Darin Adler
Comment 6 2020-04-21 21:55:53 PDT
(In reply to Alexey Proskuryakov from comment #5) > Looks like a pretty bad handgun to have such code behave differently between > build configurations. Agreed. > > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:86 > > + // FIXME: Remove this if statement once we have UChar as char16_t in all configurations. > > Is there a bug to follow to know when this happens? Bug 210845.
Alexey Proskuryakov
Comment 7 2020-04-22 14:00:40 PDT
FOOTgun :)
Note You need to log in before you can comment on or make changes to this bug.