Summary: | WTF API test for StringConcatenate failing for internal Apple builds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | Tools / Tests | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, bfulgham | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=210845 https://bugs.webkit.org/show_bug.cgi?id=209694 |
||||||
Attachments: |
|
Description
Darin Adler
2020-04-21 13:03:31 PDT
Created attachment 397107 [details]
Patch
Comment on attachment 397107 [details]
Patch
Thank you for the fix!
Committed r260452: <https://trac.webkit.org/changeset/260452> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397107 [details]. Comment on attachment 397107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397107&action=review Looks like a pretty bad handgun to have such code behave differently between build configurations. > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:86 > + // FIXME: Remove this if statement once we have UChar as char16_t in all configurations. Is there a bug to follow to know when this happens? (In reply to Alexey Proskuryakov from comment #5) > Looks like a pretty bad handgun to have such code behave differently between > build configurations. Agreed. > > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:86 > > + // FIXME: Remove this if statement once we have UChar as char16_t in all configurations. > > Is there a bug to follow to know when this happens? Bug 210845. FOOTgun :) |