Bug 210734

Summary: check-webkit-style should not complain about missing config.h header in WebKitLegacy source files
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210724
Bug Depends on: 205840    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-04-19 22:59:02 PDT
check-webkit-style should not complain about missing config.h header in WebKitLegacy source files.

This was a rather easy fix once I found that support for this was added for Source/bmalloc via Bug 205840 in r254140.

check-webkit-style: bmalloc doesn't use config.h
<https://bugs.webkit.org/show_bug.cgi?id=205840>
<https://trac.webkit.org/r254140>
Comment 1 David Kilzer (:ddkilzer) 2020-04-19 23:05:19 PDT
Created attachment 396944 [details]
Patch v1
Comment 2 Darin Adler 2020-04-19 23:13:04 PDT
Comment on attachment 396944 [details]
Patch v1

Also true for many files in WebKit, although not all. Not sure what the rule is.
Comment 3 David Kilzer (:ddkilzer) 2020-04-19 23:41:31 PDT
(In reply to Darin Adler from comment #2)
> Comment on attachment 396944 [details]
> Patch v1
> 
> Also true for many files in WebKit, although not all. Not sure what the rule
> is.

Probably things in "Cocoa" directories?  I can run the style checker and find them all (probably need to add a `grep` to that):

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WebKit

That's for another patch, though.
Comment 4 EWS 2020-04-20 01:25:38 PDT
Committed r260355: <https://trac.webkit.org/changeset/260355>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396944 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-20 01:26:18 PDT
<rdar://problem/62048173>