Bug 210734 – check-webkit-style should not complain about missing config.h header in WebKitLegacy source files

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

check-webkit-style should not complain about missing config.h header in WebKitLegacy source files.

This was a rather easy fix once I found that support for this was added for Source/bmalloc via Bug 205840 in r254140.

check-webkit-style: bmalloc doesn't use config.h
<https://bugs.webkit.org/show_bug.cgi?id=205840>
<https://trac.webkit.org/r254140>

[David Kilzer (:ddkilzer)]

Created attachment 396944 [details]
Patch v1

[Darin Adler]

Comment on attachment 396944 [details]
Patch v1

Also true for many files in WebKit, although not all. Not sure what the rule is.

[David Kilzer (:ddkilzer)]

(In reply to Darin Adler from comment #2)
> Comment on attachment 396944 [details]
> Patch v1
> 
> Also true for many files in WebKit, although not all. Not sure what the rule
> is.

Probably things in "Cocoa" directories?  I can run the style checker and find them all (probably need to add a `grep` to that):

$ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WebKit

That's for another patch, though.

[EWS]

Committed r260355: <https://trac.webkit.org/changeset/260355>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396944 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62048173>