Summary: | check-webkit-style should not complain about missing config.h header in WebKitLegacy source files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=210724 | ||||||
Bug Depends on: | 205840 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2020-04-19 22:59:02 PDT
Created attachment 396944 [details]
Patch v1
Comment on attachment 396944 [details]
Patch v1
Also true for many files in WebKit, although not all. Not sure what the rule is.
(In reply to Darin Adler from comment #2) > Comment on attachment 396944 [details] > Patch v1 > > Also true for many files in WebKit, although not all. Not sure what the rule > is. Probably things in "Cocoa" directories? I can run the style checker and find them all (probably need to add a `grep` to that): $ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WebKit That's for another patch, though. Committed r260355: <https://trac.webkit.org/changeset/260355> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396944 [details]. |