Bug 210460

Summary: Add ENABLE_CUSTOM_SCROLLBARS and define it for macOS and for non-Cocoa platforms
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: ASSIGNED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, mifenton, mmaxfield, pdr, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210479    
Bug Blocks: 210438    
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch none

Simon Fraser (smfr)
Reported 2020-04-13 15:29:00 PDT
Add ENABLE_CUSTOM_SCROLLBARS and define it for macOS and for non-Cocoa platforms
Attachments
Patch (19.77 KB, patch)
2020-04-13 15:30 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (3.75 KB, patch)
2020-04-13 20:15 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
Patch (6.58 KB, patch)
2020-04-13 21:02 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-04-13 15:30:20 PDT
Created attachment 396343 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-04-13 17:47:34 PDT
https://trac.webkit.org/changeset/260052/webkit
Radar WebKit Bug Importer
Comment 3 2020-04-13 17:48:15 PDT
<rdar://problem/61748309>
Simon Fraser (smfr)
Comment 4 2020-04-13 20:13:53 PDT
This fix wasn't complete.
Simon Fraser (smfr)
Comment 5 2020-04-13 20:15:25 PDT
Created attachment 396374 [details] Patch
Darin Adler
Comment 6 2020-04-13 20:45:44 PDT
Comment on attachment 396374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396374&action=review > Source/WTF/wtf/PlatformEnable.h:840 > -#if !defined(ENABLE_CUSTOM_SCROLLBARS) > +#if !defined(ENABLE_CUSTOM_SCROLLBARS) && !PLATFORM(COCOA) > #define ENABLE_CUSTOM_SCROLLBARS 1 > #endif This should be fixed in PlatformEnableCocoa.h instead, like this: #if !defined(ENABLE_CUSTOM_SCROLLBARS) && !PLATFORM(MAC) #define ENABLE_CUSTOM_SCROLLBARS 0 #endif PlatformEnableCocoa.h doesn't ever have to set it to 1.
Simon Fraser (smfr)
Comment 7 2020-04-13 21:02:36 PDT
Created attachment 396378 [details] Patch
Simon Fraser (smfr)
Comment 8 2020-04-13 22:32:05 PDT
Rolling out the first patch via bug 210479. I don't have time to address the iOS WK2 failures at present, will postpone this.
Note You need to log in before you can comment on or make changes to this bug.