Bug 210252

Summary: Use more PAC diversity for JIT probe code.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210254, 210314    
Bug Blocks:    
Attachments:
Description Flags
work in progress.
none
proposed patch. keith_miller: review+

Mark Lam
Reported 2020-04-09 00:50:15 PDT
<rdar://problem/54490367>
Attachments
work in progress. (9.41 KB, patch)
2020-04-09 02:34 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (11.17 KB, patch)
2020-04-10 11:25 PDT, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-04-09 02:34:53 PDT
Created attachment 395927 [details] work in progress.
Mark Lam
Comment 2 2020-04-10 11:25:47 PDT
Created attachment 396107 [details] proposed patch.
Keith Miller
Comment 3 2020-04-10 13:12:55 PDT
Comment on attachment 396107 [details] proposed patch. r=me. Can you confirm the failing JSC test isn't related to your patch though?
Mark Lam
Comment 4 2020-04-10 13:21:37 PDT
Thanks for the review. (In reply to Keith Miller from comment #3) > Comment on attachment 396107 [details] > proposed patch. > > r=me. Can you confirm the failing JSC test isn't related to your patch > though? The failing test is stress/regress-189028.js.ftl-eager. It does not reproduce for me locally. Hence, it's not due to my patch.
Mark Lam
Comment 5 2020-04-10 13:28:09 PDT
Landed in r259897: <http://trac.webkit.org/r259897>.
Mark Lam
Comment 6 2020-04-16 14:41:09 PDT
Rolled out r259897 in r260222: <http://trac.webkit.org/r260222>.
Mark Lam
Comment 7 2020-04-16 15:37:02 PDT
The issue was just a debug ASSERT that does not apply for non-ARM64E builds. Re-landed in r260223: <http://trac.webkit.org/r260223>.
Note You need to log in before you can comment on or make changes to this bug.