Summary: | Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, beidson, david_quesada, ggaren, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 208670 | ||||||
Attachments: |
|
Description
Chris Dumez
2020-04-01 13:20:19 PDT
Created attachment 395196 [details]
Patch
Comment on attachment 395196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395196&action=review > Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:136 > + FrameInfoData frameInfo { FrameInfoData is supposed to only be created in the web process because otherwise it is out of date and the frame could've navigated underneath us. I don't see another way to do this though. Committed r259362: <https://trac.webkit.org/changeset/259362> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395196 [details]. |