Bug 209543

Summary: [ews] status-bubble should link to buildbot queue while waiting in queue
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197520
https://bugs.webkit.org/show_bug.cgi?id=209598
Attachments:
Description Flags
Patch none

Description Aakash Jain 2020-03-25 07:36:55 PDT 
While a patch is waiting in queue, its ews status bubble shows position in queue, but doesn't link to anything. I would be nice if the status-bubble could link to the corresponding buildbot queue. This will allow the users to easily navigate to corresponding buildbot queue and check recent builds and pending patches in queue.
Comment 1 Aakash Jain 2020-03-25 07:39:55 PDT 
Created attachment 394493 [details]
Patch
Comment 2 Aakash Jain 2020-03-25 07:40:54 PDT 
e.g.: https://ews.webkit-uat.org/status-bubble/394352/
Comment 3 Radar WebKit Bug Importer 2020-03-25 07:41:48 PDT 
<rdar://problem/60871777>
Comment 4 Jonathan Bedard 2020-03-25 11:04:00 PDT 
Comment on attachment 394493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394493&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:99
> +            if self._get_parent_queue(queue):

Is _get_parent_queue low-cost call? Because we're calling it twice if it returns something.
Comment 5 Aakash Jain 2020-03-25 11:06:02 PDT 
Comment on attachment 394493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394493&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:99
>> +            if self._get_parent_queue(queue):
> 
> Is _get_parent_queue low-cost call? Because we're calling it twice if it returns something.

Yeah, it's just a local dictionary lookup.
Comment 6 EWS 2020-03-25 11:08:06 PDT 
Committed r258997: <https://trac.webkit.org/changeset/258997>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394493 [details].