Bug 209511

Summary: [WebGL2] Buffer updates
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, hi, jdarpinian, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404    
Attachments:
Description Flags
Patch
none
fix layout tests
none
rebase
none
fix missing trailing newline
none
actually fix missing trailing newline none

Kenneth Russell
Reported 2020-03-24 15:26:08 PDT
Buffer-related updates are needed for WebGL 2.0 in the following methods: bufferData bufferSubData getBufferParameter copyBufferSubData getBufferSubData
Attachments
Patch (9.35 KB, patch)
2020-07-30 10:50 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
fix layout tests (22.59 KB, patch)
2020-07-30 11:48 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
rebase (34.92 KB, patch)
2020-07-30 12:01 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
fix missing trailing newline (34.92 KB, patch)
2020-07-30 13:13 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
actually fix missing trailing newline (34.92 KB, patch)
2020-07-30 14:03 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-07-24 16:31:03 PDT
I will look at this one.
James Darpinian
Comment 2 2020-07-30 10:50:01 PDT
Created attachment 405590 [details] Patch
James Darpinian
Comment 3 2020-07-30 11:48:15 PDT
Created attachment 405592 [details] fix layout tests
James Darpinian
Comment 4 2020-07-30 12:01:34 PDT
Created attachment 405593 [details] rebase
James Darpinian
Comment 5 2020-07-30 13:13:48 PDT
Created attachment 405602 [details] fix missing trailing newline
Kenneth Russell
Comment 6 2020-07-30 13:22:45 PDT
Comment on attachment 405602 [details] fix missing trailing newline Fantastic work James! Looks good to me.
James Darpinian
Comment 7 2020-07-30 14:03:30 PDT
Created attachment 405612 [details] actually fix missing trailing newline
EWS
Comment 8 2020-07-30 15:27:35 PDT
Committed r265114: <https://trac.webkit.org/changeset/265114> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405612 [details].
Radar WebKit Bug Importer
Comment 9 2020-07-30 15:28:18 PDT
<rdar://problem/66350700>
Note You need to log in before you can comment on or make changes to this bug.