| Summary: | [CSS Writing Modes] Failures on WPT css-writing-modes ref-tests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | frankhome61 | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | ahmad.saleem792, bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, rbuis, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar, WPTImpact | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=214291 https://bugs.webkit.org/show_bug.cgi?id=232012 https://bugs.webkit.org/show_bug.cgi?id=236680 https://bugs.webkit.org/show_bug.cgi?id=236481 |
||||||||
| Bug Depends on: | 228914 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
frankhome61
2020-03-13 14:48:31 PDT
Created attachment 442912 [details]
Patch
Created attachment 442917 [details]
Patch
I am not a big fan of how WebKit deals with tracking WPT failures. Lumping all writing-mode tests together like this feels wrong as there will be many patches needed to fix all. In this case it can't be expected from a non WebKit committer to figure out master + sub bugs, but I expect there are similar bugs to this. Having said that, I did some writing mode fixes (one is in See also section) and may continue to work on this in my spare time to get the failing WPT writing-mode list smaller/zero. We view the checked-in copies of WPT to be regression tests, not correctness tests, so it's reasonable to check in a bunch of tests and mark most of them as failing at the same time. It also saves time later when someone does eventually make the tests pass, as they don't have to import the newly-passing tests themselves. It seems this patch didn't landed and we are still failing quite a few of css-writing tests. https://wpt.fyi/results/css/css-writing-modes?label=master&label=experimental&aligned&view=subtest&q=writing-mode I was looking into potential merge of following - https://chromium.googlesource.com/chromium/src.git/+/0f97b71bdc98d3c785b329c21134f3925f51ff3a to fix some overconstrained-* tests but noticed that this patch is pretty doing same and might fix more. So just thought to bump this. :-) Add imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-sideways-lr-writing-mode-and-rtl-direction.html to this list. |