Bug 209017
| Summary: | pep8.py:110: FutureWarning: Possible nested set at position 1 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Unspecified | ||
Michael Catanzaro
This warning occurs when running webkit-patch with python 3.7.6:
$ webkit-patch upload --request-commit
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1
EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')
I think we need to update our autoinstalled modules to replace pep8 with its replacement, pycodestyle.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Hm, sometimes I also see:
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:3599: FutureWarning: Possible nested set at position 101
check_identifier_name_in_declaration(filename, line_number, line, file_state, error)
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:3599: FutureWarning: Possible nested set at position 73
check_identifier_name_in_declaration(filename, line_number, line, file_state, error)
These are in our own code, though.
Jonathan Bedard
(In reply to Michael Catanzaro from comment #0)
> This warning occurs when running webkit-patch with python 3.7.6:
>
> $ webkit-patch upload --request-commit
> /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/
> autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1
> EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]')
>
> I think we need to update our autoinstalled modules to replace pep8 with its
> replacement, pycodestyle.
Does pycodestyle work with Python 2.7?
Our automation is still primarily Python 2.7. Although all scripts should be Python 3 compliant now, we still aren't running things that way in most places.
I think our oldest supported OS is now Mojave, so we probably aren't far from a post-Python 2 world in WebKit, but I haven't had any conversations about that it the last few weeks.
Michael Catanzaro
(In reply to Jonathan Bedard from comment #2)
> Does pycodestyle work with Python 2.7?
Apparently so.
*** This bug has been marked as a duplicate of bug 214531 ***