Bug 208947

Summary: REGRESSION (r257502): HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&) should set m_isRectBased to true
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 208254    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2020-03-11 14:48:00 PDT
In bug #208254 I inadvertently removed setting m_isRectBased to true in the constructor HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&). So, it is now set to false. This does not match the original intention of the code and should be reverted.
Attachments
Patch (1.57 KB, patch)
2020-03-11 14:52 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-03-11 14:52:37 PDT
Created attachment 393290 [details] Patch
Daniel Bates
Comment 2 2020-03-11 14:57:38 PDT
Comment on attachment 393290 [details] Patch Clearing flags on attachment: 393290 Committed r258287: <https://trac.webkit.org/changeset/258287>
Daniel Bates
Comment 3 2020-03-11 14:57:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2020-03-11 14:58:16 PDT
<rdar://problem/60342598>
Simon Fraser (smfr)
Comment 5 2020-03-11 17:35:33 PDT
Did the error cause layout test failures? Should this patch have landed with a test?
Daniel Bates
Comment 6 2020-03-11 17:42:26 PDT
(In reply to Simon Fraser (smfr) from comment #5) > Did the error cause layout test failures? Should this patch have landed with > a test? I don't know. I found this issue by code inspection. When I have a moment I will look to write one.
Note You need to log in before you can comment on or make changes to this bug.