Bug 208936

Summary: [GPU Process] encodeNativeImage() should pass imageSize to GraphicsContext::drawNativeImage()
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: CanvasAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, mmaxfield, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2020-03-11 12:37:39 PDT
The current call in encodeNativeImage() passes an empty FloatSize for the argument 'imageSize'. This causes the NativeImage not be be drawn to the ShareableBitmap. So encoding the NativeImage was always sending zero image from the WebProcess to the GPUProcess.
Attachments
Patch (1.57 KB, patch)
2020-03-11 12:44 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-03-11 12:44:02 PDT
Created attachment 393277 [details] Patch
Said Abou-Hallawa
Comment 2 2020-03-11 12:44:35 PDT
This patch lowers the failures of the command run-webkit-tests --debug --no-retry LayoutTests/canvas/ LayoutTests/fast/canvas --internal-feature RenderCanvasInGPUProcessEnabled from 69 to 45 (after the patch of https://bugs.webkit.org/show_bug.cgi?id=208876 and https://bugs.webkit.org/show_bug.cgi?id=208931).
WebKit Commit Bot
Comment 3 2020-03-11 21:25:04 PDT
Comment on attachment 393277 [details] Patch Clearing flags on attachment: 393277 Committed r258312: <https://trac.webkit.org/changeset/258312>
WebKit Commit Bot
Comment 4 2020-03-11 21:25:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-03-11 21:26:17 PDT
<rdar://problem/60355796>
Note You need to log in before you can comment on or make changes to this bug.