| Summary: | Fix LayoutTests that call notifyDone() twice | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Tools / Tests | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, rwlbuis | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2008-09-16 10:29:14 PDT
I get occasional failures in fast/dom/gc-9.html, which suggest that fast/dom/gc-7.html or fast/dom/gc-8.html are doing something bad. A test prior to svg/custom/gradient-cycle-detection.html also seems to have issues. Bug 20881 covers animations/change-one-anim.html Looks like gradient-attr-update.svg can call notifyDone() twice because myfunc() is called both by the onload, and by the onclick. I'm not sure how to fix that test. Created attachment 23483 [details]
Fix test to not call notifyDone() twice
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/animations/change-one-anim.html M LayoutTests/svg/custom/gradient-attr-update.svg Committed r36520 Keeping bug open for fast/dom/gc-8.html Comment on attachment 23483 [details]
Fix test to not call notifyDone() twice
rs=me -- needs ChangeLog -- fix seems a little indirect to me, but should be fine
Will land. I'll add a ChangeLog because I'm that nice. Comment on attachment 23483 [details]
Fix test to not call notifyDone() twice
Clearing review flag. This has already been landed. Keeping open per comment above.
I don't think anything remains now. |