Bug 208804

Summary: Remove SampleBufferDisplayLayer sync IPC
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2020-03-09 05:00:35 PDT
Remove SampleBufferDisplayLayer sync IPC
Attachments
Patch (35.09 KB, patch)
2020-03-09 05:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (35.18 KB, patch)
2020-03-10 06:08 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (35.17 KB, patch)
2020-03-10 07:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-03-09 05:16:13 PDT
Created attachment 393022 [details] Patch
Eric Carlson
Comment 2 2020-03-09 06:13:25 PDT
Comment on attachment 393022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393022&action=review r=me if the bots are happy > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:385 > + [m_boundsChangeListener begin: m_sampleBufferDisplayLayer->rootLayer()]; Nit: don't need a space after the ':'
youenn fablet
Comment 3 2020-03-10 06:08:33 PDT
Created attachment 393140 [details] Patch for landing
WebKit Commit Bot
Comment 4 2020-03-10 07:00:00 PDT
Comment on attachment 393140 [details] Patch for landing Rejecting attachment 393140 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 393140, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13337675
youenn fablet
Comment 5 2020-03-10 07:03:28 PDT
Created attachment 393145 [details] Patch for landing
WebKit Commit Bot
Comment 6 2020-03-10 07:42:14 PDT
The commit-queue encountered the following flaky tests while processing attachment 393145 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-03-10 07:42:52 PDT
Comment on attachment 393145 [details] Patch for landing Clearing flags on attachment: 393145 Committed r258208: <https://trac.webkit.org/changeset/258208>
WebKit Commit Bot
Comment 8 2020-03-10 07:42:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-03-10 07:43:20 PDT
<rdar://problem/60272200>
Note You need to log in before you can comment on or make changes to this bug.