Bug 208690

Summary: [Cocoa] Re-enable CFPrefs direct mode
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208784
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Per Arne Vollan
Reported 2020-03-05 20:05:47 PST
Re-enable CFPrefs direct mode, and address performance and Accessibility issues.
Attachments
Patch (22.08 KB, patch)
2020-03-05 20:22 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (24.17 KB, patch)
2020-03-05 21:12 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (23.30 KB, patch)
2020-03-06 07:43 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (24.58 KB, patch)
2020-03-06 10:39 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (24.81 KB, patch)
2020-03-06 11:29 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (33.91 KB, patch)
2020-03-06 12:10 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (32.65 KB, patch)
2020-03-06 13:49 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (45.46 KB, patch)
2020-03-06 16:56 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (45.47 KB, patch)
2020-03-06 17:53 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.91 KB, patch)
2020-03-11 17:15 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-03-05 20:22:38 PST
Created attachment 392664 [details] Patch
Per Arne Vollan
Comment 2 2020-03-05 21:12:01 PST
Created attachment 392670 [details] Patch
Per Arne Vollan
Comment 3 2020-03-06 07:43:35 PST
Created attachment 392720 [details] Patch
Per Arne Vollan
Comment 4 2020-03-06 10:39:10 PST
Created attachment 392742 [details] Patch
Per Arne Vollan
Comment 5 2020-03-06 11:29:41 PST
Created attachment 392748 [details] Patch
Per Arne Vollan
Comment 6 2020-03-06 12:10:34 PST
Created attachment 392751 [details] Patch
Per Arne Vollan
Comment 7 2020-03-06 13:49:15 PST
Created attachment 392769 [details] Patch
Per Arne Vollan
Comment 8 2020-03-06 16:56:48 PST
Created attachment 392813 [details] Patch
Brent Fulgham
Comment 9 2020-03-06 17:25:15 PST
Comment on attachment 392813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392813&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:342 > +- (void)_grantAccessToPreferenceService WK_API_AVAILABLE(ios(WK_IOS_TBA)); I think this should be macOS(WK_MAC_TBA), too, shouldn't it?
Per Arne Vollan
Comment 10 2020-03-06 17:53:18 PST
Created attachment 392821 [details] Patch
Per Arne Vollan
Comment 11 2020-03-06 17:54:06 PST
(In reply to Brent Fulgham from comment #9) > Comment on attachment 392813 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392813&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:342 > > +- (void)_grantAccessToPreferenceService WK_API_AVAILABLE(ios(WK_IOS_TBA)); > > I think this should be macOS(WK_MAC_TBA), too, shouldn't it? Fixed. Thanks for reviewing!
WebKit Commit Bot
Comment 12 2020-03-06 22:57:28 PST
The commit-queue encountered the following flaky tests while processing attachment 392821 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 160571 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 13 2020-03-06 22:58:14 PST
Comment on attachment 392821 [details] Patch Clearing flags on attachment: 392821 Committed r258064: <https://trac.webkit.org/changeset/258064>
Radar WebKit Bug Importer
Comment 14 2020-03-07 07:25:17 PST
<rdar://problem/60188065>
Per Arne Vollan
Comment 15 2020-03-11 17:15:43 PDT
Reopening to attach new patch.
Per Arne Vollan
Comment 16 2020-03-11 17:15:44 PDT
Created attachment 393312 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.