Bug 208000

Summary:

[GTK] Web inspector related tests very slow or timeout in debug mode

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Web Inspector

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex, bugs-noreply, cgarcia, don.olmstead, dpino, ews-watchlist, fujii.hironori, hi, inspector-bugzilla-changes, joepeck, lmoura, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=207711
https://bugs.webkit.org/show_bug.cgi?id=149916

Attachments:

Description	Flags
WIP patch	none
WIP patch	none
WIP patch	none
Patch	none

Carlos Alberto Lopez Perez

Reported 2020-02-20 04:08:03 PST

All (or alsmot all) Web inspector related tests timeout in debug builds, from at least since december-2019. GTK debug bot has been aborting early since then.

Attachments
WIP patch (686 bytes, patch) 2021-02-23 22:58 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
WIP patch (3.12 KB, patch) 2021-02-24 12:16 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
WIP patch (6.56 KB, patch) 2021-03-01 14:07 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (9.77 KB, patch) 2021-03-01 18:34 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2020-02-20 05:09:06 PST

I have marked all Web inspector related tests as slow in r257051 for Debug. I was going to mark them as timing out, but I decided to give them a run locally to check if in slow they passed and most of them did. I just marked as timing out the ones that timed out locally. Will check on the Debug bot after the next run if there are more timing outs and if needed mark them as timing out if this continues to be an issue.

Carlos Alberto Lopez Perez

Comment 2 2020-02-20 05:09:38 PST

See also bug 149916

Carlos Alberto Lopez Perez

Comment 3 2020-02-20 18:54:32 PST

Ok, the debug bot has stopped exiting early due to this unexpected timeouts, and we now most of the inspector tests are completing the run in debug, just marked as slow so the testrunner gives them extra time to run. There are still some issues with the Web inspector tests there on the last run. Many giving text failure, one timeout and one crash. https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/5941

Fujii Hironori

Comment 4 2021-02-23 22:58:54 PST

Created attachment 421387 [details] WIP patch

Fujii Hironori

Comment 5 2021-02-24 12:16:40 PST

Created attachment 421437 [details] WIP patch

Fujii Hironori

Comment 6 2021-02-24 12:33:53 PST

Comment on attachment 421437 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=421437&action=review > Source/WebInspectorUI/UserInterface/Protocol/MessageDispatcher.js:33 > + const timeLimitPerRunLoop = 100; // milliseconds This code was add by Bug 135427 (r171881). It is very old. There should be any recent changes increasing processing time.

Fujii Hironori

Comment 7 2021-03-01 14:07:22 PST

Created attachment 421864 [details] WIP patch WI.dispatchNextQueuedMessageFromBackend is using setTimeout, but it is very slow because it is throttled by 1 second.

Fujii Hironori

Comment 8 2021-03-01 17:48:44 PST

This is a bug ticket for Mac. Bug 147456 – LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1

Fujii Hironori

Comment 9 2021-03-01 18:34:15 PST

Created attachment 421896 [details] Patch

Fujii Hironori

Comment 10 2021-03-01 22:59:32 PST

Comment on attachment 421896 [details] Patch Clearing flags on attachment: 421896 Committed r273724 (234739@main): <https://commits.webkit.org/234739@main>

Fujii Hironori

Comment 11 2021-03-01 22:59:38 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2021-03-01 23:00:17 PST

<rdar://problem/74912815>

Fujii Hironori

Comment 13 2021-03-01 23:01:10 PST

*** Bug 149916 has been marked as a duplicate of this bug. ***

Don Olmstead

Comment 14 2021-03-02 07:52:08 PST

Looks like the Windows client is also missing this switch. Any way we could make this more cross platform?

Note You need to log in before you can comment on or make changes to this bug.