Bug 207975

Summary: Crash in Page::updateRendering when document has no domWindow
Product: WebKit Reporter: Sunny He <sunny_he>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sunny He
Reported 2020-02-19 17:03:30 PST
rdar://56999099
Attachments
Patch (2.09 KB, patch)
2020-02-19 17:09 PST, Sunny He 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2020-02-20 17:55 PST, Sunny He 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sunny He
Comment 1 2020-02-19 17:09:09 PST
Created attachment 391223 [details] Patch
Ryosuke Niwa
Comment 2 2020-02-20 11:49:16 PST
Comment on attachment 391223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review > Source/WebCore/page/Page.cpp:1334 > + if (document.domWindow()) { Can we use an early return instead?
Said Abou-Hallawa
Comment 3 2020-02-20 16:18:14 PST
Comment on attachment 391223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391223&action=review >> Source/WebCore/page/Page.cpp:1334 >> + if (document.domWindow()) { > > Can we use an early return instead? Should this be in forEachDocument()? Is there a reason to run any rendering update step for a document which does not have a window?
Ryosuke Niwa
Comment 4 2020-02-20 17:41:47 PST
(In reply to Said Abou-Hallawa from comment #3) > Comment on attachment 391223 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391223&action=review > > >> Source/WebCore/page/Page.cpp:1334 > >> + if (document.domWindow()) { > > > > Can we use an early return instead? > > Should this be in forEachDocument()? Is there a reason to run any rendering > update step for a document which does not have a window? I don’t think we want to do that there because it’s used in other places than Page::updateRendering.
Sunny He
Comment 5 2020-02-20 17:55:09 PST
Created attachment 391365 [details] Patch
WebKit Commit Bot
Comment 6 2020-02-20 18:57:28 PST
The commit-queue encountered the following flaky tests while processing attachment 391365 [details]: editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com) fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-02-20 18:57:59 PST
Comment on attachment 391365 [details] Patch Clearing flags on attachment: 391365 Committed r257123: <https://trac.webkit.org/changeset/257123>
WebKit Commit Bot
Comment 8 2020-02-20 18:58:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.