Bug 207556

Summary: [ews] add SetBuildSummary step for Windows EWS
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2020-02-11 09:10:26 PST
add SetBuildSummary step for Windows EWS. Follow-up to Bug 207492.
Attachments
Patch (3.16 KB, patch)
2020-02-11 09:16 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (3.16 KB, patch)
2020-02-11 09:22 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-02-11 09:16:16 PST
Created attachment 390373 [details] Patch
Aakash Jain
Comment 2 2020-02-11 09:22:06 PST
Created attachment 390374 [details] Patch
Jonathan Bedard
Comment 3 2020-02-11 14:29:33 PST
Comment on attachment 390374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390374&action=review > Tools/ChangeLog:10 > + (GTKBuildAndTestFactory.__init__): Adding it for GTK too?
Aakash Jain
Comment 4 2020-02-11 14:33:02 PST
This change would fix the build summary for builds like this: https://ews-build.webkit.org/#/builders/10/builds/7056
Aakash Jain
Comment 5 2020-02-11 14:33:25 PST
(In reply to Jonathan Bedard from comment #3) > Adding it for GTK too? Yes, because GTK factory also have the same layout-test step which was modified in Bug 207492. Although that code path is not used currently by any GTK factory.
Aakash Jain
Comment 6 2020-02-17 08:49:05 PST
Committed r256729: <https://trac.webkit.org/changeset/256729>
Radar WebKit Bug Importer
Comment 7 2020-02-17 08:50:18 PST
<rdar://problem/59512176>
Note You need to log in before you can comment on or make changes to this bug.